Don't compute CommandManager.toString() (#428)

johanvos · web-flow · commit 62c93490ac96 · 2025-12-15T12:18:46.000+01:00
* Don't unconditionally compute parameters of LOG.info(); Fix #427
diff --git a/rta/src/main/java/com/gluonhq/richtextarea/undo/CommandManager.java b/rta/src/main/java/com/gluonhq/richtextarea/undo/CommandManager.java
@@ -56,7 +56,7 @@ public void execute(AbstractCommand<T> cmd) {
         undoStack.push(cmd);
         redoStack.clear();
         end();
-        LOGGER.log(Level.FINE, "Execute: " + this);
+        LOGGER.log(Level.FINE, () -> "Execute: " + this);
     }
 
     public void undo() {
@@ -65,7 +65,7 @@ public void undo() {
             cmd.undo(context);
             redoStack.push(cmd);
             end();
-            LOGGER.log(Level.FINE, "Undo: " + this);
+            LOGGER.log(Level.FINE, () -> "Undo: " + this);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -56,7 +56,7 @@ public void execute(AbstractCommand<T> cmd) {`
`56`	`56`	`undoStack.push(cmd);`
`57`	`57`	`redoStack.clear();`
`58`	`58`	`end();`
`59`		`- LOGGER.log(Level.FINE, "Execute: " + this);`
	`59`	`+ LOGGER.log(Level.FINE, () -> "Execute: " + this);`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`public void undo() {`
`@@ -65,7 +65,7 @@ public void undo() {`
`65`	`65`	`cmd.undo(context);`
`66`	`66`	`redoStack.push(cmd);`
`67`	`67`	`end();`
`68`		`- LOGGER.log(Level.FINE, "Undo: " + this);`
	`68`	`+ LOGGER.log(Level.FINE, () -> "Undo: " + this);`
`69`	`69`	`}`
`70`	`70`	`}`
`71`	`71`