Invalid Parameters returned from AccountTxRequest callout

[JoeyGii]

Thanks for doing this SDK. I've had great success with it. I had to redo the signing aspect for submitting payments, but other than that smooth sailing.

However, the above struct seems to be a little wonky. I get an invalidParameters response from it.

When I made my own struct and implemented your Request trait I had a successful response.

[gmosx]

Re signing payments, any chance you could submit a PR?

Same for AccountTxRequest?

That would be greatly appreciated.

[tinkrtailor]

@JoeyGii What did the struct you made look like? Wondering if we can spot the difference and update the library accordingly

[JoeyGii]

pub struct AccountTxsRequest {
    account: String,
    binary: bool,
    forward: bool,
    ledger_index_max: i64,
    ledger_index_min: i64,
    limit: u64,
}

I got it working with the above by using the xrpl documentation. @gunnigylfa

[JoeyGii]

I also used these defaults:

impl AccountTxsRequest {
    pub fn new(account: &str) -> AccountTxsRequest {
        AccountTxsRequest {
            account: account.into(),
            binary: false,
            forward: false,
            ledger_index_max: -1,
            ledger_index_min: -1,
            limit: 5,
        }
    }
}

[tinkrtailor]

Thanks for sharing this. FWIW the AccountTxsRequest is working without modifications in my applications.