refactored Orientation into enum for usage in various orientation attributes

Author: gmuth

src/main/kotlin/de/gmuth/ipp/attributes/Orientation.kt

@@ -0,0 +1,13 @@
+package de.gmuth.ipp.attributes
+
+/**
+ * Copyright (c) 2020-2024 Gerhard Muth
+ */
+
+enum class Orientation(val code: Int) {
+    Portrait(3),
+    Landscape(4),
+    ReverseLandscape(5),
+    ReversePortrait(6),
+    None(7); // PWG 5100.13
+}

src/main/kotlin/de/gmuth/ipp/attributes/OrientationRequested.kt

@@ -48,6 +48,10 @@ object TemplateAttributes {
     fun finishings(values: Collection<Finishing>) =
         IppAttribute("finishings", IppTag.Enum, values.map { it.code })
 
+    @JvmStatic
+    fun orientationRequested(orientation: Orientation) =
+        IppAttribute("orientation-requested", IppTag.Enum, orientation.code)
+
     @JvmStatic
     fun mediaSource(keyword: String) =
         IppAttribute("media-source", Keyword, keyword)

src/main/kotlin/de/gmuth/ipp/attributes/TemplateAttributes.kt

@@ -1,29 +1,29 @@
 package de.gmuth.ipp.client
 
 /**
- * Copyright (c) 2021-2023 Gerhard Muth
+ * Copyright (c) 2021-2024 Gerhard Muth
  */
 
 import de.gmuth.ipp.attributes.*
 import de.gmuth.ipp.attributes.Finishing.Punch
 import de.gmuth.ipp.attributes.Finishing.Staple
+import de.gmuth.ipp.attributes.Orientation.Portrait
 import de.gmuth.ipp.attributes.PrinterType.Capability.CanPunchOutput
 import de.gmuth.ipp.attributes.TemplateAttributes.copies
 import de.gmuth.ipp.attributes.TemplateAttributes.finishings
 import de.gmuth.ipp.attributes.TemplateAttributes.jobName
 import de.gmuth.ipp.attributes.TemplateAttributes.jobPriority
 import de.gmuth.ipp.attributes.TemplateAttributes.numberUp
+import de.gmuth.ipp.attributes.TemplateAttributes.orientationRequested
 import de.gmuth.ipp.attributes.TemplateAttributes.pageRanges
 import de.gmuth.ipp.attributes.TemplateAttributes.printerResolution
 import de.gmuth.ipp.client.WhichJobs.Completed
 import de.gmuth.ipp.core.IppOperation.GetPrinterAttributes
-import de.gmuth.ipp.attributes.Marker
 import java.io.File
 import java.io.FileInputStream
 import java.net.URI
 import java.util.logging.Logger.getLogger
 import kotlin.io.path.createTempDirectory
-import kotlin.io.path.pathString
 import kotlin.test.Test
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
@@ -120,7 +120,7 @@ class IppPrinterTests {
             numberUp(1),
             pageRanges(1..5),
             printerResolution(600),
-            OrientationRequested.Portrait,
+            orientationRequested(Portrait),
             ColorMode.Monochrome,
             Sides.TwoSidedLongEdge,
             PrintQuality.High,