feat: refactor r/gnoland/valopers to remove r/sys/validators dependency (#3830)

fixes #3567

Objectives:

- [x] The `/r/gnoland/valopers` should not have the dependency on
`/r/sys/validators`. So a new realm will do the glue between the
`valopers` realm and the `validators` valset.
  - [x] remove dependency
  - [x] write glue contract
  - [x] write glue contract tests
- [x] As an admin, I can edit the instructions to register a new
valoper, espacially for what to put in the description field. So a
public function is needed to update the instructions and an
administration mechanism to restrict calls.
- [x] Change the API to be able to call valopers' functions directly
with a JS frontend (Connect, Adena), in one call. So we have to only use
primitive types on parameters and remove objects. We also have to create
new functions to update valopers for the desired fields.
- [x] Make functions more robust by implementing parameter validation.
- [x] Add protection on update functions so only the original caller can
update its valoper.
- [x] Prevent SPAM by the need of sending coins when you want to
register as a valoper.
- [x] Enhance the Render function with a pagination feature.

Process to be a validator:
1) Register your validator node as a `Valoper` with the
`r/gnolang/valopers.Register` function. Follow the instructions set in
the `Instructions` global variable (to be done).
2) When you think your valoper is ready, make a GovDao proposal to add
it to the validator valset with
`/r/gnoland/valopers_proposal.MakeProposal`.

In local environment, the two steps can be done by:

```
gnokey maketx call \
  -pkgpath "gno.land/r/gnoland/valopers" \
  -func "Register" \
  -gas-fee 1000000ugnot \
  -gas-wanted 30000000 \
  -send "20000000ugnot" \
  -broadcast \
  -chainid "dev" \
  -args "berty" \
  -args "Berty's validator description" \
  -args "g1ut590acnamvhkrh4qz6dz9zt9e3hyu499u0gvl" \
  -args "gpub1pgfj7ard9eg82cjtv4u4xetrwqer2dntxyfzxz3pq0skzdkmzu0r9h6gny6eg8c9dc303xrrudee6z4he4y7cs5rnjwmyf40yaj" \
  -remote "tcp://127.0.0.1:26657" \
  test1

gnokey maketx call \
  -pkgpath "gno.land/r/gnoland/valopers_proposal" \
  -func "ProposeNewValidator" \
  -gas-fee 1000000ugnot \
  -gas-wanted 20000000 \
  -send "100000000ugnot" \
  -broadcast \
  -chainid "dev" \
  -args "g1ut590acnamvhkrh4qz6dz9zt9e3hyu499u0gvl" \
  -remote "tcp://127.0.0.1:26657" \
  test1
```

---------

Signed-off-by: D4ryl00 <[email protected]>
Signed-off-by: Jeff Thompson <[email protected]>
Co-authored-by: Jeff Thompson <[email protected]>
Co-authored-by: Miloš Živković <[email protected]>

Author: 3 people

examples/gno.land/r/gnoland/valopers/admin.gno

@@ -0,0 +1,55 @@
+package valopers
+
+import (
+	"std"
+
+	"gno.land/p/demo/dao"
+	"gno.land/p/moul/authz"
+	"gno.land/r/gov/dao/bridge"
+)
+
+var auth *authz.Authorizer
+
+func Auth() *authz.Authorizer {
+	return auth
+}
+
+func updateInstructions(newInstructions string) {
+	err := auth.Do("update-instructions", func() error {
+		instructions = newInstructions
+		return nil
+	})
+
+	if err != nil {
+		panic(err)
+	}
+}
+
+func updateMinFee(newMinFee int64) {
+	err := auth.Do("update-min-fee", func() error {
+		minFee = std.NewCoin("ugnot", newMinFee)
+		return nil
+	})
+
+	if err != nil {
+		panic(err)
+	}
+}
+
+func NewInstructionsExecutor(newInstructions string) dao.Executor {
+	cb := func() error {
+		updateInstructions(newInstructions)
+		return nil
+	}
+
+	return bridge.GovDAO().NewGovDAOExecutor(cb)
+}
+
+func NewMinFeeExecutor(newMinFee int64) dao.Executor {
+	cb := func() error {
+		updateMinFee(newMinFee)
+		return nil
+	}
+
+	return bridge.GovDAO().NewGovDAOExecutor(cb)
+}

examples/gno.land/r/gnoland/valopers/admin_test.gno

@@ -0,0 +1,59 @@
+package valopers
+
+import (
+	"std"
+	"testing"
+
+	"gno.land/p/demo/uassert"
+	"gno.land/p/moul/authz"
+)
+
+func TestUpdateInstructions(t *testing.T) {
+	auth = authz.NewWithAuthority(
+		authz.NewContractAuthority(
+			"gno.land/r/gov/dao/v2",
+			func(title string, action authz.PrivilegedAction) error {
+				return action()
+			},
+		),
+	)
+
+	newInstructions := "new instructions"
+
+	uassert.PanicsWithMessage(t, "action can only be executed by the contract", func() {
+		updateInstructions(newInstructions)
+	})
+
+	std.TestSetOriginCaller(std.DerivePkgAddr("gno.land/r/gov/dao/v2"))
+
+	uassert.NotPanics(t, func() {
+		updateInstructions(newInstructions)
+	})
+
+	uassert.Equal(t, newInstructions, instructions)
+}
+
+func TestUpdateMinFee(t *testing.T) {
+	auth = authz.NewWithAuthority(
+		authz.NewContractAuthority(
+			"gno.land/r/gov/dao/v2",
+			func(title string, action authz.PrivilegedAction) error {
+				return action()
+			},
+		),
+	)
+
+	newMinFee := int64(100)
+
+	uassert.PanicsWithMessage(t, "action can only be executed by the contract", func() {
+		updateMinFee(newMinFee)
+	})
+
+	std.TestSetOriginCaller(std.DerivePkgAddr("gno.land/r/gov/dao/v2"))
+
+	uassert.NotPanics(t, func() {
+		updateMinFee(newMinFee)
+	})
+
+	uassert.Equal(t, newMinFee, minFee.Amount)
+}

examples/gno.land/r/gnoland/valopers/gno.mod

@@ -0,0 +1 @@
+module gno.land/r/gnoland/valopers

examples/gno.land/r/gnoland/valopers/init.gno

@@ -0,0 +1,83 @@
+package valopers
+
+import (
+	"gno.land/p/demo/avl"
+	"gno.land/p/moul/authz"
+)
+
+func init() {
+	valopers = avl.NewTree()
+
+	auth = authz.NewWithAuthority(
+		authz.NewContractAuthority(
+			"gno.land/r/gov/dao/v2",
+			func(title string, action authz.PrivilegedAction) error {
+				return action()
+			},
+		),
+	)
+
+	instructions = `
+# Welcome to the **Valopers** realm
+
+## 📌 Purpose of this Contract
+
+The **Valopers** contract is designed to maintain a registry of **validator profiles**. This registry provides essential information to **GovDAO members**, enabling them to make informed decisions when voting on the inclusion of new validators into the **valset**.
+
+By registering your validator profile, you contribute to a transparent and well-informed governance process within **gno.land**.
+
+---
+
+## 📝 How to Register Your Validator Node
+
+To add your validator node to the registry, use the **Register** function with the following parameters:
+
+- **Moniker** (Validator Name)
+  - Must be **human-readable**
+  - **Max length**: **32 characters**
+  - **Allowed characters**: Letters, numbers, spaces, hyphens (**-**), and underscores (**_**)
+  - **No special characters** at the beginning or end
+
+- **Description** (Introduction & Validator Details)
+  - **Max length**: **2048 characters**
+  - Must include answers to the questions listed below
+
+- **Validator Address**
+  - Your validator node’s address
+
+- **Validator Public Key**
+  - Your validator node’s public key
+
+### ✍️ Required Information for the Description
+
+Please provide detailed answers to the following questions to ensure transparency and improve your chances of being accepted:
+
+1. The name of your validator
+2. Networks you are currently validating and your total AuM (assets under management)
+3. Links to your **digital presence** (website, social media, etc.).
+4. Contact details
+5. Why are you interested in validating on **gno.land**?
+6. What contributions have you made or are willing to make to **gno.land**?
+
+---
+
+## 🔄 Updating Your Validator Information
+
+After registration, you can update your validator details using the **update functions** provided by the contract.
+
+---
+
+## 📢 Submitting a Proposal to Join the Validator Set
+
+Once you're satisfied with your **valoper** profile, you can propose your inclusion into the validator set. To do so, execute the following function: **r/gnoland/valopers_proposal.MakeProposal**
+
+This will initiate a governance process where **GovDAO** members will vote on your proposal.
+
+---
+
+🚀 **Register now and become a part of gno.land’s validator ecosystem!**
+
+---
+
+`
+}