chore: alternative for 4905

Signed-off-by: moul <[email protected]>

Author: moul

gno.land/pkg/gnoland/mock_test.go

@@ -171,7 +171,7 @@ func (m *mockParamsKeeper) GetString(ctx sdk.Context, key string, ptr *string)
 func (m *mockParamsKeeper) GetInt64(ctx sdk.Context, key string, ptr *int64)      {}
 func (m *mockParamsKeeper) GetUint64(ctx sdk.Context, key string, ptr *uint64)    {}
 func (m *mockParamsKeeper) GetBool(ctx sdk.Context, key string, ptr *bool)        {}
-func (m *mockParamsKeeper) GetBytes(ctx sdk.Context, key string) []byte           { return nil }
+func (m *mockParamsKeeper) GetBytes(ctx sdk.Context, key string, ptr *[]byte)     {}
 func (m *mockParamsKeeper) GetStrings(ctx sdk.Context, key string, ptr *[]string) {}
 
 func (m *mockParamsKeeper) SetString(ctx sdk.Context, key string, value string)    {}

tm2/pkg/sdk/params/handler.go

@@ -53,7 +53,8 @@ func (bh paramsHandler) Query(ctx sdk.Context, req abci.RequestQuery) (res abci.
 				std.ErrUnknownRequest(fmt.Sprintf("module not registered: %q", module)))
 			return
 		}
-		val := bh.params.GetBytes(ctx, rest)
+		var val []byte
+		bh.params.GetBytes(ctx, rest, &val)
 		res.Data = val
 		return
 

tm2/pkg/sdk/params/keeper.go

@@ -38,7 +38,7 @@ type ParamsKeeperI interface {
 	SetStrings(ctx sdk.Context, key string, value []string)
 
 	Has(ctx sdk.Context, key string) bool
-	GetBytes(ctx sdk.Context, key string) []byte
+	GetBytes(ctx sdk.Context, key string, ptr *[]byte)
 	SetBytes(ctx sdk.Context, key string, value []byte)
 
 	GetStruct(ctx sdk.Context, key string, strctPtr any)
@@ -124,8 +124,12 @@ func (pk ParamsKeeper) GetUint64(ctx sdk.Context, key string, ptr *uint64) {
 	pk.getIfExists(ctx, key, ptr)
 }
 
-func (pk ParamsKeeper) GetBytes(ctx sdk.Context, key string) []byte {
-	return ctx.Store(pk.key).Get(storeKey(key))
+func (pk ParamsKeeper) GetBytes(ctx sdk.Context, key string, ptr *[]byte) {
+	stor := ctx.Store(pk.key)
+	bz := stor.Get(storeKey(key))
+	if bz != nil {
+		*ptr = bz
+	}
 }
 
 func (pk ParamsKeeper) GetStrings(ctx sdk.Context, key string, ptr *[]string) {
@@ -287,8 +291,8 @@ func (ppk prefixParamsKeeper) GetBool(ctx sdk.Context, key string, ptr *bool) {
 	ppk.pk.GetBool(ctx, ppk.prefixed(key), ptr)
 }
 
-func (ppk prefixParamsKeeper) GetBytes(ctx sdk.Context, key string) []byte {
-	return ppk.pk.GetBytes(ctx, ppk.prefixed(key))
+func (ppk prefixParamsKeeper) GetBytes(ctx sdk.Context, key string, ptr *[]byte) {
+	ppk.pk.GetBytes(ctx, ppk.prefixed(key), ptr)
 }
 
 func (ppk prefixParamsKeeper) GetStrings(ctx sdk.Context, key string, ptr *[]string) {

tm2/pkg/sdk/params/keeper_test.go

@@ -45,7 +45,7 @@ func TestKeeper(t *testing.T) {
 	require.NotPanics(t, func() { keeper.GetBool(ctx, "param2", &param2) })
 	require.NotPanics(t, func() { keeper.GetUint64(ctx, "param3", &param3) })
 	require.NotPanics(t, func() { keeper.GetInt64(ctx, "param4", &param4) })
-	require.NotPanics(t, func() { param5 = keeper.GetBytes(ctx, "param5") })
+	require.NotPanics(t, func() { keeper.GetBytes(ctx, "param5", &param5) })
 
 	require.Equal(t, param1, "foo")
 	require.Equal(t, param2, true)
@@ -70,7 +70,7 @@ func TestKeeper(t *testing.T) {
 	require.NotPanics(t, func() { keeper.GetBool(ctx, "param2", &param2) })
 	require.NotPanics(t, func() { keeper.GetUint64(ctx, "param3", &param3) })
 	require.NotPanics(t, func() { keeper.GetInt64(ctx, "param4", &param4) })
-	require.NotPanics(t, func() { param5 = keeper.GetBytes(ctx, "param5") })
+	require.NotPanics(t, func() { keeper.GetBytes(ctx, "param5", &param5) })
 
 	require.Equal(t, param1, "bar")
 	require.Equal(t, param2, false)