Skip to content

Commit e6df4f3

Browse files
0Keithclaude
andauthored
docs: correct the CodeQL recovery step for older PRs (#182)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent a2c3771 commit e6df4f3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎CLAUDE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ Enforced via `.editorconfig`: .NET 10, C#, file-scoped namespaces, 4-space inden
145145
- "Remember" = update `CLAUDE.md` (not just the memory directory)
146146
- **Merging:** Land every PR with `gh pr merge --squash --auto`. Every commit reaching `main` is signed regardless of local setup, because GitHub creates the squash commit itself and signs it with its web-flow key. Branch commits are deliberately *not* required to be signed: the ruleset's `required_signatures` rule was removed, since PRs are mandatory and the squash commit is signed either way. While that rule was active it refused the merge outright - even with `--auto` armed and all checks green - because it evaluates the branch commits before GitHub ever creates the signed squash commit.
147147
- **Branch protection on `main`:** ruleset requires PRs, squash-only, linear history, and both `build` and `CodeQL` status checks; no bypass actors (owner cannot bypass)
148-
- **CodeQL:** code scanning default setup (`actions` + `csharp`) supplies the required `CodeQL` check. It only attaches to PRs opened *after* it was enabled - a PR predating that must be closed and reopened for the check to appear
148+
- **CodeQL:** code scanning default setup (`actions` + `csharp`) supplies the required `CodeQL` check. It only attaches to PRs opened *after* it was enabled. Closing and reopening an older PR does not trigger it. Push a new commit to the branch, an empty one is enough, for the check to appear.
149149
- **Always start work on a feature branch** - never commit directly to `main`; create a descriptive branch (e.g., `feature/wallpaper-preview`, `fix/auto-update`) before making any changes
150150
- **Comment addition tasks:** Add comments in small, focused batches (1–3 files at a time) rather than delegating all files to a single agent. Large batches risk code corruption.
151151
- **Verify Linux changes against the real desktop**, not the app log - read the desktop's own state (e.g. `gsettings get org.gnome.desktop.background picture-uri`). Setup is in `docs/platform-support.md`.

0 commit comments

Comments
 (0)