add: making a DAO with random adresse from validator list

Author: Nezketsu

packages/r/greg007/gnobounty/application.gno

@@ -52,10 +52,12 @@ func ApplyForBounty(_ realm, bountyID uint64, prLink string) uint64 {
 	daoDesc := ufmt.Sprintf("Private DAO to review application for bounty #%d", bountyID)
 
 	// Create DAO with selected validators as members
+	// DisableVotingDeadlineCheck allows immediate execution after votes
 	dao := commondao.New(
 		commondao.WithID(applicationCount),
 		commondao.WithName(daoName),
 		commondao.WithDescription(daoDesc),
+		commondao.DisableVotingDeadlineCheck(),
 	)
 
 	// Add selected validators as members
@@ -136,6 +138,22 @@ func Vote(_ realm, applicationID uint64, vote string) {
 	if err != nil {
 		panic(err)
 	}
+
+	// Try to execute the proposal
+	// Tally() will return true when all validators have voted
+	// Execute() will handle both approval and rejection
+	proposal = app.DAO.ActiveProposals().Get(app.ProposalID)
+	if proposal != nil {
+		totalMembers := app.DAO.Members().Size()
+		totalVotes := proposal.VotingRecord().Size()
+
+		// If all validators have voted, execute to finalize
+		if totalVotes == totalMembers {
+			err = app.DAO.Execute(app.ProposalID)
+			// Ignore errors - proposal might already be executed or failed
+			// The status will be updated in Execute() regardless
+		}
+	}
 }
 
 // GetApplicationsForBounty returns all applications for a specific bounty

packages/r/greg007/gnobounty/proposal.gno

@@ -47,28 +47,28 @@ func (p *ClaimBountyProposal) VotingPeriod() time.Duration {
 	return 7 * 24 * time.Hour
 }
 
-// Tally counts votes and determines if proposal passes
-// Requires all 3 validators to vote YES for approval
+// Tally counts votes and determines if proposal is ready to execute
+// Returns true when all validators have voted (regardless of outcome)
 func (p *ClaimBountyProposal) Tally(votes commondao.ReadonlyVotingRecord, members commondao.MemberSet) (bool, error) {
 	totalMembers := members.Size()
 	if totalMembers == 0 {
 		return false, ufmt.Errorf("no members in DAO")
 	}
 
-	// Count votes using the VoteCount method
-	yesCount := votes.VoteCount(commondao.ChoiceYes)
-	noCount := votes.VoteCount(commondao.ChoiceNo)
+	totalVotes := votes.Size()
 
-	// Require 100% approval: all validators must vote YES
-	// For a 3-validator DAO, we need exactly 3 YES votes
-	if yesCount == totalMembers && noCount == 0 {
+	// Return true when all validators have voted
+	// This allows Execute to be called and handle approval/rejection
+	if totalVotes == totalMembers {
 		return true, nil
 	}
 
+	// Not ready yet - waiting for more votes
 	return false, nil
 }
 
-// Execute executes the proposal after approval
+// Execute executes the proposal after all votes are in
+// Determines approval or rejection based on vote counts
 func (p *ClaimBountyProposal) Execute(_ realm) error {
 	app := GetApplication(p.ApplicationID)
 	if app == nil {
@@ -84,19 +84,34 @@ func (p *ClaimBountyProposal) Execute(_ realm) error {
 		return ufmt.Errorf("bounty already claimed")
 	}
 
-	// Mark application as approved
-	app.Status = StatusApproved
+	// Get vote counts from the DAO proposal
+	proposal := app.DAO.ActiveProposals().Get(app.ProposalID)
+	if proposal == nil {
+		return ufmt.Errorf("proposal not found")
+	}
 
-	// Mark bounty as claimed
-	bounty.IsClaimed = true
-	bounty.Claimer = p.Applicant
-	bounty.ClaimedAt = time.Now()
+	yesCount := proposal.VotingRecord().VoteCount(commondao.ChoiceYes)
+	noCount := proposal.VotingRecord().VoteCount(commondao.ChoiceNo)
+	totalMembers := app.DAO.Members().Size()
 
-	// Transfer bounty amount to applicant
-	bnk := banker.NewBanker(banker.BankerTypeRealmSend)
-	send := chain.Coins{chain.Coin{Denom: "ugnot", Amount: bounty.Amount}}
-	pkgAddr := chain.PackageAddress("gno.land/r/greg007/gnobounty")
-	bnk.SendCoins(pkgAddr, p.Applicant, send)
+	// Check if unanimous approval (all YES, no NO)
+	if yesCount == totalMembers && noCount == 0 {
+		// Approve and transfer funds
+		app.Status = StatusApproved
+
+		bounty.IsClaimed = true
+		bounty.Claimer = p.Applicant
+		bounty.ClaimedAt = time.Now()
+
+		// Transfer bounty amount to applicant
+		bnk := banker.NewBanker(banker.BankerTypeRealmSend)
+		send := chain.Coins{chain.Coin{Denom: "ugnot", Amount: bounty.Amount}}
+		pkgAddr := chain.PackageAddress("gno.land/r/greg007/gnobounty")
+		bnk.SendCoins(pkgAddr, p.Applicant, send)
+	} else {
+		// Reject - not unanimous
+		app.Status = StatusRejected
+	}
 
 	return nil
 }

packages/r/greg007/gnobounty/render.gno

@@ -137,7 +137,51 @@ func renderApplication(app *Application) string {
 	// Show DAO voting information if DAO exists
 	if app.DAO != nil {
 		output += ufmt.Sprintf("- Proposal ID: %d\n", app.ProposalID)
-		output += ufmt.Sprintf("- Validators: %d assigned\n", app.DAO.Members().Size())
+
+		// Get proposal and show detailed validator voting status
+		proposal := app.DAO.ActiveProposals().Get(app.ProposalID)
+		if proposal != nil {
+			// Get vote counts
+			yesCount := proposal.VotingRecord().VoteCount(commondao.ChoiceYes)
+			noCount := proposal.VotingRecord().VoteCount(commondao.ChoiceNo)
+			abstainCount := proposal.VotingRecord().VoteCount(commondao.ChoiceAbstain)
+			totalVotes := proposal.VotingRecord().Size()
+			totalMembers := app.DAO.Members().Size()
+
+			output += ufmt.Sprintf("\n**Voting Progress:** %d/%d validators have voted\n", totalVotes, totalMembers)
+			output += ufmt.Sprintf("- ✅ YES: %d\n", yesCount)
+			output += ufmt.Sprintf("- ❌ NO: %d\n", noCount)
+			output += ufmt.Sprintf("- 🤷 ABSTAIN: %d\n", abstainCount)
+			output += ufmt.Sprintf("- ⏳ PENDING: %d\n", totalMembers-totalVotes)
+		}
+	}
+
+	// Add vote buttons for validators if application is still pending
+	if app.Status == StatusPending && app.DAO != nil {
+		output += "\n**Vote on this application:**\n"
+
+		// Add vote buttons (yes/no/abstain)
+		yesLink := txlink.NewLink("Vote").
+			AddArgs(
+				"applicationID", ufmt.Sprintf("%d", app.ID),
+				"vote", "yes",
+			).
+			URL()
+		noLink := txlink.NewLink("Vote").
+			AddArgs(
+				"applicationID", ufmt.Sprintf("%d", app.ID),
+				"vote", "no",
+			).
+			URL()
+		abstainLink := txlink.NewLink("Vote").
+			AddArgs(
+				"applicationID", ufmt.Sprintf("%d", app.ID),
+				"vote", "abstain",
+			).
+			URL()
+
+		output += md.Link("✅ Approve", yesLink) + " | " + md.Link("❌ Reject", noLink) + " | " + md.Link("🤷 Abstain", abstainLink) + "\n"
+		output += "\n_Note: Only assigned validators can vote on this application._\n"
 	}
 	output += "\n"