add: remove placeholder in tx and add a leaderboard

Author: Nezketsu

packages/r/greg007/gnobounty/application.gno

@@ -139,6 +139,12 @@ func Vote(_ realm, applicationID uint64, vote string) {
 		panic(err)
 	}
 
+	// Record vote locally
+	app.Votes = append(app.Votes, VoteRecord{
+		Voter:  caller,
+		Choice: voteChoice,
+	})
+
 	// Try to execute the proposal
 	// Tally() will return true when all validators have voted
 	// Execute() will handle both approval and rejection
@@ -178,12 +184,10 @@ func GetApplicationsForValidator(validatorAddr address) []*Application {
 	applications.Iterate("", "", func(key string, value interface{}) bool {
 		app := value.(*Application)
 		// Check if validator is a member of the application's DAO
-		// We need to check if this validator was selected for this application
-		// by iterating through applications and checking the selected validators
 		if app.DAO != nil && app.Status == StatusPending {
-			// We can't easily get the members from the DAO interface
-			// Instead, we'll add the application and let the validator see all pending ones
-			apps = append(apps, app)
+			if app.DAO.Members().Has(validatorAddr) {
+				apps = append(apps, app)
+			}
 		}
 		return false
 	})

packages/r/greg007/gnobounty/leaderboard.gno

@@ -0,0 +1,128 @@
+package gnobounty
+
+import (
+	"gno.land/p/nt/ufmt"
+)
+
+// LeaderboardEntry holds the stats for a user
+type LeaderboardEntry struct {
+	Address              address
+	BountiesCreated      int
+	BountiesApplied      int
+	ValidationsPerformed int
+	Score                int
+}
+
+// GetLeaderboard aggregates stats for all users
+func GetLeaderboard() []LeaderboardEntry {
+	stats := make(map[address]*LeaderboardEntry)
+
+	getEntry := func(addr address) *LeaderboardEntry {
+		if _, ok := stats[addr]; !ok {
+			stats[addr] = &LeaderboardEntry{Address: addr}
+		}
+		return stats[addr]
+	}
+
+	// Count bounties created (10 points)
+	bounties.Iterate("", "", func(key string, value interface{}) bool {
+		if value == nil {
+			return false
+		}
+		bounty, ok := value.(*Bounty)
+		if !ok || bounty == nil {
+			return false
+		}
+		entry := getEntry(bounty.Creator)
+		entry.BountiesCreated++
+		entry.Score += 10
+		return false
+	})
+
+	// Count applications and validations
+	applications.Iterate("", "", func(key string, value interface{}) bool {
+		if value == nil {
+			return false
+		}
+		app, ok := value.(*Application)
+		if !ok || app == nil {
+			return false
+		}
+		
+		// Only count approved applications (20 points)
+		if app.Status == StatusApproved {
+			entry := getEntry(app.Applicant)
+			entry.BountiesApplied++
+			entry.Score += 20
+		}
+
+		// Count validations from local record (5 points)
+		for _, vote := range app.Votes {
+			entry := getEntry(vote.Voter)
+			entry.ValidationsPerformed++
+			entry.Score += 5
+		}
+		
+		return false
+	})
+
+	// Convert map to slice
+	var result []LeaderboardEntry
+	for _, entry := range stats {
+		result = append(result, *entry)
+	}
+
+	// Sort by Score descending
+	// Manual bubble sort since sort.Slice is not available
+	for i := 0; i < len(result)-1; i++ {
+		for j := 0; j < len(result)-i-1; j++ {
+			if result[j].Score < result[j+1].Score {
+				// Swap
+				result[j], result[j+1] = result[j+1], result[j]
+			}
+		}
+	}
+
+	return result
+}
+
+// RenderLeaderboard renders the leaderboard page
+func RenderLeaderboard() string {
+	entries := GetLeaderboard()
+
+	output := "# 🏆 Community Leaderboard\n\n"
+	output += "Top contributors to the GnoBounty ecosystem.\n\n"
+	output += "**Scoring:** Bounty Creation (10pts) | Approved Application (20pts) | Validation (5pts)\n\n"
+
+	output += "| Rank | User | Score | 💰 Bounties | 📝 Applications | ⚖️ Validations |\n"
+	output += "|---|---|---|---|---|---|\n"
+
+	for i, entry := range entries {
+		rank := ""
+		switch i {
+		case 0:
+			rank = "🥇"
+		case 1:
+			rank = "🥈"
+		case 2:
+			rank = "🥉"
+		default:
+			rank = ufmt.Sprintf("%d", i+1)
+		}
+
+		output += ufmt.Sprintf("| %s | %s | **%d** | %d | %d | %d |\n",
+			rank,
+			entry.Address,
+			entry.Score,
+			entry.BountiesCreated,
+			entry.BountiesApplied,
+			entry.ValidationsPerformed,
+		)
+	}
+
+	if len(entries) == 0 {
+		output += "\nNo activity recorded yet."
+	}
+
+	return output
+}

packages/r/greg007/gnobounty/logic.gno

@@ -10,16 +10,20 @@ import (
 )
 
 // CreateBounty creates a new bounty post
+// title: short title for the bounty
 // issueURL: link to the GitHub issue or other issue tracker
 // description: description of what needs to be done
 // Caller must send GNOT tokens with this transaction
-func CreateBounty(_ realm, issueURL, description string) uint64 {
+func CreateBounty(_ realm, title, issueURL, description string) uint64 {
 	// Validate inputs
+	if title == "" {
+		panic("title is required")
+	}
 	if issueURL == "" {
-		panic("issue URL cannot be empty")
+		panic("issue URL is required")
 	}
 	if description == "" {
-		panic("description cannot be empty")
+		panic("description is required")
 	}
 
 	// Get the sent coins
@@ -45,6 +49,7 @@ func CreateBounty(_ realm, issueURL, description string) uint64 {
 	bountyCount++
 	bounty := &Bounty{
 		ID:          bountyCount,
+		Title:       title,
 		IssueURL:    issueURL,
 		Description: description,
 		Amount:      gnotAmount,

packages/r/greg007/gnobounty/render.gno

@@ -14,8 +14,9 @@ func ListBounties() string {
 	minSend := ufmt.Sprintf("%dugnot", minimumBounty)
 	createBountyLink := txlink.NewLink("CreateBounty").
 		AddArgs(
-			"issueURL", "https://github.com/your-org/your-repo/issues/123",
-			"description", "Describe the work your bounty covers",
+			"title", "",
+			"issueURL", "",
+			"description", "",
 		).
 		SetSend(minSend).
 		URL()
@@ -31,6 +32,8 @@ func ListBounties() string {
 	output += ufmt.Sprintf(" _(minimum reward: %s)_", minSend)
 	output += " | "
 	output += md.Link("📋 View All Validators", "/r/greg007/gnobounty:validators")
+	output += " | "
+	output += md.Link("🏆 Leaderboard", "/r/greg007/gnobounty:leaderboard")
 	output += "\n\n"
 
 	// Add validator stats
@@ -39,6 +42,7 @@ func ListBounties() string {
 
 	output += "---\n\n"
 	output += "## 💎 Active Bounties\n\n"
+	output += "**How to apply:** To apply to a bounty, you need to give your **MERGED PR** (important) URL in the transaction. You also need to write your Gno address in the description of your PR to verify your identity. If no address is written, the bounty can be refused.\n\n"
 
 	if bountyCount == 0 {
 		output += "No bounties available"
@@ -48,7 +52,7 @@ func ListBounties() string {
 	bounties.Iterate("", "", func(key string, value interface{}) bool {
 		bounty := value.(*Bounty)
 		if !bounty.IsClaimed {
-			output += ufmt.Sprintf("## Bounty #%d\n", bounty.ID)
+			output += ufmt.Sprintf("## Bounty #%d: %s\n", bounty.ID, bounty.Title)
 			output += ufmt.Sprintf("**Issue:** %s\n", bounty.IssueURL)
 			output += ufmt.Sprintf("**Description:** %s\n", bounty.Description)
 			output += ufmt.Sprintf("**Reward:** %d ugnot (%.2f GNOT)\n", bounty.Amount, float64(bounty.Amount)/1000000.0)
@@ -59,7 +63,7 @@ func ListBounties() string {
 			applyLink := txlink.NewLink("ApplyForBounty").
 				AddArgs(
 					"bountyID", ufmt.Sprintf("%d", bounty.ID),
-					"prLink", "https://github.com/your-org/your-repo/pull/123",
+					"prLink", "",
 				).
 				URL()
 			output += md.Link("📝 Apply for this bounty", applyLink)
@@ -83,7 +87,7 @@ func GetBountyDetails(id uint64) string {
 		return "Bounty not found"
 	}
 
-	output := ufmt.Sprintf("# Bounty #%d\n\n", bounty.ID)
+	output := ufmt.Sprintf("# Bounty #%d: %s\n\n", bounty.ID, bounty.Title)
 	output += ufmt.Sprintf("**Issue URL:** %s\n", bounty.IssueURL)
 	output += ufmt.Sprintf("**Description:** %s\n", bounty.Description)
 	output += ufmt.Sprintf("**Reward:** %d ugnot (%.2f GNOT)\n", bounty.Amount, float64(bounty.Amount)/1000000.0)
@@ -96,12 +100,13 @@ func GetBountyDetails(id uint64) string {
 		output += ufmt.Sprintf("**Claimed at:** %s\n", bounty.ClaimedAt.Format("2006-01-02 15:04:05"))
 	} else {
 		output += ufmt.Sprintf("**Status:** OPEN\n\n")
+		output += "**How to apply:** To apply to a bounty, you need to give your **MERGED PR** (important) URL in the transaction. You also need to write your Gno address in the description of your PR to verify your identity. If no address is written, the bounty can be refused.\n\n"
 
 		// Add apply button
 		applyLink := txlink.NewLink("ApplyForBounty").
 			AddArgs(
 				"bountyID", ufmt.Sprintf("%d", id),
-				"prLink", "https://github.com/your-org/your-repo/pull/123",
+				"prLink", "",
 			).
 			URL()
 		output += md.Link("Apply for this bounty", applyLink) + "\n\n"
@@ -267,15 +272,10 @@ func RenderValidators() string {
 	output := ListValidators()
 
 	// Add register button
-	registerValidatorLink := txlink.NewLink("AddValidator").
-		AddArgs(
-			"validatorAddr", "your_address_here",
-		).
-		URL()
+	registerValidatorLink := txlink.NewLink("AddValidator").URL()
 	output += "## Register\n\n"
 	output += md.Link("👨‍⚖️ Register as Validator", registerValidatorLink)
 	output += "\n\n"
-	output += "_Note: Replace 'your_address_here' with your actual address when registering._\n"
 
 	return output
 }
@@ -291,6 +291,10 @@ func Render(path string) string {
 		return RenderValidators()
 	}
 
+	if path == "leaderboard" {
+		return RenderLeaderboard()
+	}
+
 	// Parse bounty ID from path
 	id, err := strconv.Atoi(path)
 	if err != nil {

packages/r/greg007/gnobounty/types.gno

@@ -9,6 +9,7 @@ import (
 // Bounty represents a bounty post for an issue
 type Bounty struct {
 	ID          uint64
+	Title       string // Short title for the bounty
 	IssueURL    string
 	Description string
 	Amount      int64 // Amount in ugnot
@@ -29,6 +30,13 @@ type Application struct {
 	Status     ApplicationStatus
 	DAO        *commondao.CommonDAO // Private DAO for this application
 	ProposalID uint64               // Proposal ID in the DAO
+	Votes      []VoteRecord         // Local record of votes
+}
+
+// VoteRecord represents a vote cast by a validator
+type VoteRecord struct {
+	Voter  address
+	Choice commondao.VoteChoice
 }
 
 // ApplicationStatus represents the status of an application