Pythonic support: improvements to collections

[cbm755]

See comments in CI/CD main.yml.

[alexvong243f]

------- Original Message -------

On Saturday, June 18th, 2022 at 4:04 PM, Colin B. Macdonald ***@***.***> wrote: @cbm755 commented on this pull request. In .github/workflows/main.yml: > + sudo git config --global --add safe.directory /home/jovyan/octsympy + docker exec oc apt-get update + docker exec oc apt-get install -y libpython3-dev + docker exec oc pip3 install packaging + docker exec oc pip3 install sympy=="$SYMPY" + docker exec oc octave-cli --eval "pwd; ls" + docker exec oc octave-cli --eval "pkg install -forge doctest" + docker exec oc \ + git clone https://gitlab.com/mtmiller/octave-pythonic.git + # FIXME: Workaround the following error + # --8<---------------cut here---------------start------------->8--- + # error: subsref: cannot index Python object, not sequence or callable + # --8<---------------cut here---------------end--------------->8--- + # by replacing all occurences of + # "py.collections.Callable" to "py.collections.abc.Callable" and + # "py.collections.Sequence" to "py.collections.abc.Sequence" I guess we need some new issue to fix this properly rather than sed'ing around it.

Yeah the sed trick is more a hack than a proper fix. @chrisjohgorman mentioned in #1067 (comment) that he had a fix waiting to be merged to upstream pythonic. Maybe this is what we want.

…

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[cbm755]

I looked over the CI main.yml file: I think this sed business is hacking pythonic not our code. So nothing in particular need done in Symbolic for 3.0.0.