void static analyser warnings

Author: rfm

Source/NSFileCoordinator.m

@@ -150,9 +150,8 @@ - (void)coordinateAccessWithIntents: (NSArray *)intents
                          byAccessor: (GSAccessorCallbackHandler)accessor
 {
   NSEnumerator *en = [intents objectEnumerator];
-  id obj = nil;
 
-  while ((obj = [en nextObject]) != nil)
+  while ([en nextObject] != nil)
     {
       NSBlockOperation *op;
 

Tools/pl2link.m

@@ -212,7 +212,12 @@
       NSString *execPath = nil;
       int l = 0;
 
-      fp = popen("which openapp","r");
+      if (NULL == (fp = popen("which openapp","r")))
+	{
+	  GSPrintf(stderr, @"Unable to find 'openapp' to open '%@'\n", entry);
+	  [pool release];
+	  exit(EXIT_FAILURE);
+	}
       fgets(line,sizeof line,fp);
       l = strlen(line);
       line[l-1] = '\0';