Skip to content

Commit b77b870

Browse files
authored
namedotcom: follow CNAME (#2390)
1 parent eed3f0d commit b77b870

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

providers/dns/namedotcom/namedotcom.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,10 @@ func NewDNSProviderConfig(config *Config) (*DNSProvider, error) {
116116
func (d *DNSProvider) Present(domain, token, keyAuth string) error {
117117
info := dns01.GetChallengeInfo(domain, keyAuth)
118118

119-
// TODO(ldez) replace domain by FQDN to follow CNAME.
119+
if info.EffectiveFQDN != info.FQDN {
120+
domain = dns01.UnFqdn(info.EffectiveFQDN)
121+
}
122+
120123
domainDetails, err := d.client.GetDomain(&namecom.GetDomainRequest{DomainName: domain})
121124
if err != nil {
122125
return fmt.Errorf("namedotcom: API call failed: %w", err)
@@ -127,7 +130,6 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
127130
return fmt.Errorf("namedotcom: %w", err)
128131
}
129132

130-
// TODO(ldez) replace domain by FQDN to follow CNAME.
131133
request := &namecom.Record{
132134
DomainName: domain,
133135
Host: subDomain,
@@ -148,15 +150,17 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
148150
func (d *DNSProvider) CleanUp(domain, token, keyAuth string) error {
149151
info := dns01.GetChallengeInfo(domain, keyAuth)
150152

151-
// TODO(ldez) replace domain by FQDN to follow CNAME.
153+
if info.EffectiveFQDN != info.FQDN {
154+
domain = dns01.UnFqdn(info.EffectiveFQDN)
155+
}
156+
152157
records, err := d.getRecords(domain)
153158
if err != nil {
154159
return fmt.Errorf("namedotcom: %w", err)
155160
}
156161

157162
for _, rec := range records {
158163
if rec.Fqdn == info.EffectiveFQDN && rec.Type == "TXT" {
159-
// TODO(ldez) replace domain by FQDN to follow CNAME.
160164
request := &namecom.DeleteRecordRequest{
161165
DomainName: domain,
162166
ID: rec.ID,

0 commit comments

Comments
 (0)