ssa2pal: globals should be WithPointer

+ a bit of debug cleanup

Author: scott-cotton

objects/builder.go

@@ -15,12 +15,10 @@
 package objects
 
 import (
-	"fmt"
 	"go/token"
 	"go/types"
 
 	"github.com/go-air/pal/indexing"
-	"github.com/go-air/pal/internal/plain"
 	"github.com/go-air/pal/memory"
 	"github.com/go-air/pal/typeset"
 )
@@ -226,7 +224,7 @@ func (b *Builder) Func(sig *types.Signature, declName string, opaque memory.Attr
 // everywhere...
 func (b *Builder) walkObj(m memory.Loc) {
 	ty := b.mmod.Type(m)
-	fmt.Printf("walkObj %s ty %s\n", plain.String(m), b.ts.String(ty))
+	//fmt.Printf("walkObj %s ty %s\n", plain.String(m), b.ts.String(ty))
 	ki := b.ts.Kind(ty)
 	switch ki {
 	case typeset.Basic:

ssa2pal/debug.go

@@ -17,8 +17,9 @@ package ssa2pal
 const (
 	tracePackage = true
 	traceFunc    = true
+	traceParam   = false
 
-	debugLogModel    = true
+	debugLogModel    = false
 	traceGenValueLoc = false
 	traceGenExtract  = false
 	traceGenNext     = false

ssa2pal/t.go

@@ -136,7 +136,8 @@ func (p *T) genGlobal(name string, x *ssa.Global) {
 	}
 	switch ty := x.Type().Underlying().(type) {
 	case *types.Pointer:
-		p.vmap[x] = p.buildr.Pointer(ty).Loc()
+		_, ptr := p.buildr.GoType(ty.Elem().Underlying()).WithPointer()
+		p.vmap[x] = ptr
 	default:
 		msg := fmt.Sprintf(
 			"unexpected ssa global member type for %s %T\n",
@@ -160,7 +161,7 @@ func (p *T) addFuncDecl(name string, fn *ssa.Function) error {
 	p.vmap[fn] = memFn.Loc()
 
 	for i, param := range fn.Params {
-		if traceFunc {
+		if traceParam {
 			fmt.Printf("setting param %s to %s\n", param, plain.String(memFn.ParamLoc(i)))
 
 		}