modify review comments

hzp-excellent · web-flow · commit 8409d2b3cfbe · 2025-02-18T10:04:06.000+08:00
diff --git a/addresspool/pool.go b/addresspool/pool.go
@@ -237,8 +237,9 @@ func (p *Pool) checkConnectivity() {
 	p.mutex.Lock()
 	p.status = status
 	p.statusHistory = append(p.statusHistory, status)
-	if len(p.statusHistory) > 3 {
-		p.statusHistory = p.statusHistory[1:]
+	cnt := len(p.statusHistory)
+	if cnt > 3 {
+		p.statusHistory = p.statusHistory[(cnt - 3):]
 	}
 	p.mutex.Unlock()
 }

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,9 @@ func (p *Pool) checkConnectivity() {`
`237`	`237`	`p.mutex.Lock()`
`238`	`238`	`p.status = status`
`239`	`239`	`p.statusHistory = append(p.statusHistory, status)`
`240`		`- if len(p.statusHistory) > 3 {`
`241`		`- p.statusHistory = p.statusHistory[1:]`
	`240`	`+ cnt := len(p.statusHistory)`
	`241`	`+ if cnt > 3 {`
	`242`	`+ p.statusHistory = p.statusHistory[(cnt - 3):]`
`242`	`243`	`}`
`243`	`244`	`p.mutex.Unlock()`
`244`	`245`	`}`