Simplify test to validate log line filtering behavior

Co-authored-by: silverwind <115237+silverwind@users.noreply.github.com>

Author: Copilot

web_src/js/components/RepoActionView.test.ts

@@ -18,93 +18,68 @@ function shouldHideLine(line: LogLine): boolean {
   return false;
 }
 
-test('shouldHideLine filters workflow commands starting with ::add-matcher::', () => {
-  const line: LogLine = {
-    index: 1,
-    timestamp: 1000,
-    message: '::add-matcher::.github/problem-matcher.json',
-  };
-  expect(shouldHideLine(line)).toBe(true);
-});
-
-test('shouldHideLine filters workflow commands starting with ##[add-matcher]', () => {
-  const line: LogLine = {
-    index: 2,
-    timestamp: 1001,
-    message: '##[add-matcher].github/eslint.json',
-  };
-  expect(shouldHideLine(line)).toBe(true);
-});
+// Simulate the filtering behavior of appendLogs
+function filterLogLines(logLines: LogLine[]): LogLine[] {
+  return logLines.filter((line) => !shouldHideLine(line));
+}
 
-test('shouldHideLine filters workflow commands starting with ::workflow-command', () => {
-  const line: LogLine = {
-    index: 3,
-    timestamp: 1002,
-    message: '::workflow-command::some-command',
-  };
-  expect(shouldHideLine(line)).toBe(true);
-});
+test('filters workflow command lines from log output', () => {
+  // Input: log lines including workflow commands that should be hidden
+  const inputLogLines: LogLine[] = [
+    {index: 1, timestamp: 1000, message: 'Starting build process'},
+    {index: 2, timestamp: 1001, message: '::add-matcher::.github/problem-matcher.json'},
+    {index: 3, timestamp: 1002, message: 'Running tests...'},
+    {index: 4, timestamp: 1003, message: '##[add-matcher].github/eslint.json'},
+    {index: 5, timestamp: 1004, message: 'Test suite started'},
+    {index: 6, timestamp: 1005, message: '::workflow-command::echo some-output'},
+    {index: 7, timestamp: 1006, message: 'All tests passed'},
+    {index: 8, timestamp: 1007, message: '::remove-matcher::owner=eslint'},
+    {index: 9, timestamp: 1008, message: 'Build complete'},
+  ];
 
-test('shouldHideLine filters workflow commands starting with ::remove-matcher', () => {
-  const line: LogLine = {
-    index: 4,
-    timestamp: 1003,
-    message: '::remove-matcher::owner=eslint',
-  };
-  expect(shouldHideLine(line)).toBe(true);
-});
+  // Expected output: only non-workflow-command lines
+  const expectedVisibleMessages = [
+    'Starting build process',
+    'Running tests...',
+    'Test suite started',
+    'All tests passed',
+    'Build complete',
+  ];
 
-test('shouldHideLine does not filter normal log lines', () => {
-  const line: LogLine = {
-    index: 5,
-    timestamp: 1004,
-    message: 'Normal log line without workflow commands',
-  };
-  expect(shouldHideLine(line)).toBe(false);
-});
+  // Filter the lines
+  const visibleLines = filterLogLines(inputLogLines);
 
-test('shouldHideLine does not filter lines with workflow commands not at the start', () => {
-  const line: LogLine = {
-    index: 6,
-    timestamp: 1005,
-    message: 'Some text before ::add-matcher:: in the middle',
-  };
-  expect(shouldHideLine(line)).toBe(false);
-});
+  // Assert the correct number of lines are visible
+  expect(visibleLines.length).toBe(5);
 
-test('shouldHideLine handles group commands (should not hide them)', () => {
-  const groupLine: LogLine = {
-    index: 7,
-    timestamp: 1006,
-    message: '::group::Build Step',
-  };
-  expect(shouldHideLine(groupLine)).toBe(false);
+  // Assert the visible lines contain the expected messages
+  const visibleMessages = visibleLines.map((line) => line.message);
+  expect(visibleMessages).toEqual(expectedVisibleMessages);
 
-  const endGroupLine: LogLine = {
-    index: 8,
-    timestamp: 1007,
-    message: '::endgroup::',
-  };
-  expect(shouldHideLine(endGroupLine)).toBe(false);
+  // Assert that workflow command lines are not in the output
+  expect(visibleMessages).not.toContain('::add-matcher::.github/problem-matcher.json');
+  expect(visibleMessages).not.toContain('##[add-matcher].github/eslint.json');
+  expect(visibleMessages).not.toContain('::workflow-command::echo some-output');
+  expect(visibleMessages).not.toContain('::remove-matcher::owner=eslint');
 });
 
-test('shouldHideLine handles various log formats', () => {
-  const testCases = [
-    {message: '::add-matcher::', expected: true},
-    {message: '##[add-matcher]', expected: true},
-    {message: '::workflow-command', expected: true},
-    {message: '::remove-matcher', expected: true},
-    {message: 'Build started', expected: false},
-    {message: 'Error: test failed', expected: false},
-    {message: '  ::add-matcher::.github/test.json', expected: false}, // with leading space
+test('preserves non-workflow command lines including group commands', () => {
+  const inputLogLines: LogLine[] = [
+    {index: 1, timestamp: 1000, message: 'Normal log line'},
+    {index: 2, timestamp: 1001, message: '::group::Installation'},
+    {index: 3, timestamp: 1002, message: 'Installing dependencies'},
+    {index: 4, timestamp: 1003, message: '::add-matcher::.github/npm.json'},
+    {index: 5, timestamp: 1004, message: '::endgroup::'},
+    {index: 6, timestamp: 1005, message: 'Done'},
   ];
 
-  for (const [index, {message, expected}] of testCases.entries()) {
-    const line: LogLine = {
-      index: index + 10,
-      timestamp: 2000 + index,
-      message,
-    };
-    expect(shouldHideLine(line)).toBe(expected);
-  }
+  const visibleLines = filterLogLines(inputLogLines);
+
+  // Should have 5 lines (all except the ::add-matcher:: line)
+  expect(visibleLines.length).toBe(5);
+
+  const visibleMessages = visibleLines.map((line) => line.message);
+  expect(visibleMessages).toContain('::group::Installation');
+  expect(visibleMessages).toContain('::endgroup::');
+  expect(visibleMessages).not.toContain('::add-matcher::.github/npm.json');
 });