Skip to content

Commit 9d89dfe

Browse files
authored
Remove unused or abused styles (#33918)
* `top aligned` => `tw-align-top` * label list: it was broken, this PR fixes it * reference link: simplified * settings/repos: not affected
1 parent 9ebae4a commit 9d89dfe

File tree

8 files changed

+13
-64
lines changed

8 files changed

+13
-64
lines changed

templates/package/content/container.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
<tbody>
8383
{{range $key, $value := .PackageDescriptor.Metadata.Labels}}
8484
<tr>
85-
<td class="top aligned">{{$key}}</td>
85+
<td class="tw-align-top">{{$key}}</td>
8686
<td class="tw-break-anywhere">{{$value}}</td>
8787
</tr>
8888
{{end}}

templates/repo/issue/labels/label_list.tmpl

+5-7
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,11 @@
6363

6464
{{if and (not .PageIsOrgSettingsLabels) (.OrgLabels)}}
6565
<li class="item">
66-
<div class="ui grid middle aligned">
67-
<div class="ten wide column">
68-
{{ctx.Locale.Tr "repo.org_labels_desc"}}
69-
{{if .IsOrganizationOwner}}
70-
<a href="{{.OrganizationLink}}/settings/labels">({{ctx.Locale.Tr "repo.org_labels_desc_manage"}})</a>:
71-
{{end}}
72-
</div>
66+
<div>{{/* parent is flex, so use block here to keep sentence spaces */}}
67+
{{ctx.Locale.Tr "repo.org_labels_desc"}}
68+
{{if .IsOrganizationOwner}}
69+
<a href="{{.OrganizationLink}}/settings/labels">({{ctx.Locale.Tr "repo.org_labels_desc_manage"}})</a>:
70+
{{end}}
7371
</div>
7472
</li>
7573

Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<div class="divider"></div>
2-
<div class="ui equal width compact grid">
3-
{{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}}
4-
<div class="row tw-items-center" data-tooltip-content="{{$issueReferenceLink}}">
5-
<span class="text column truncate">{{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}}</span>
6-
<button class="ui two wide button column tw-p-2" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
7-
</div>
2+
{{$issueReferenceLink := printf "%s#%d" .Issue.Repo.FullName .Issue.Index}}
3+
<div class="flex-text-block" data-tooltip-content="{{$issueReferenceLink}}">
4+
<span class="tw-flex-1 gt-ellipsis">{{ctx.Locale.Tr "repo.issues.reference_link" $issueReferenceLink}}</span>
5+
<button class="ui compact tiny icon button" data-clipboard-text="{{$issueReferenceLink}}">{{svg "octicon-copy" 14}}</button>
86
</div>

templates/user/settings/repos.tmpl

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181
{{end}}
8282
{{else}}
8383
{{if .Repos}}
84-
<div class="ui middle aligned divided list">
84+
<div class="ui list">
8585
{{range .Repos}}
8686
<div class="item">
8787
<div class="content flex-text-block">

web_src/css/modules/grid.css

-22
Original file line numberDiff line numberDiff line change
@@ -393,28 +393,6 @@
393393
margin-right: 2.5rem;
394394
}
395395

396-
.ui[class*="middle aligned"].grid > .column:not(.row),
397-
.ui[class*="middle aligned"].grid > .row > .column,
398-
.ui.grid > [class*="middle aligned"].row > .column,
399-
.ui.grid > [class*="middle aligned"].column:not(.row),
400-
.ui.grid > .row > [class*="middle aligned"].column {
401-
flex-direction: column;
402-
vertical-align: middle;
403-
align-self: center !important;
404-
}
405-
406-
.ui[class*="equal width"].grid > .column:not(.row),
407-
.ui[class*="equal width"].grid > .row > .column,
408-
.ui.grid > [class*="equal width"].row > .column {
409-
display: inline-block;
410-
flex-grow: 1;
411-
}
412-
.ui[class*="equal width"].grid > .wide.column,
413-
.ui[class*="equal width"].grid > .row > .wide.column,
414-
.ui.grid > [class*="equal width"].row > .wide.column {
415-
flex-grow: 0;
416-
}
417-
418396
@media only screen and (max-width: 767.98px) {
419397
.ui[class*="mobile reversed"].grid,
420398
.ui[class*="mobile reversed"].grid > .row,

web_src/css/modules/table.css

-10
Original file line numberDiff line numberDiff line change
@@ -152,16 +152,6 @@
152152
}
153153
}
154154

155-
.ui.table[class*="top aligned"],
156-
.ui.table [class*="top aligned"] {
157-
vertical-align: top;
158-
}
159-
160-
.ui.table[class*="middle aligned"],
161-
.ui.table [class*="middle aligned"] {
162-
vertical-align: middle;
163-
}
164-
165155
.ui.table th.collapsing,
166156
.ui.table td.collapsing {
167157
width: 1px;

web_src/fomantic/build/components/form.css

-10
Original file line numberDiff line numberDiff line change
@@ -1499,16 +1499,6 @@
14991499
width: 100%;
15001500
}
15011501

1502-
/*--------------------
1503-
Equal Width
1504-
---------------------*/
1505-
1506-
.ui[class*="equal width"].form .fields > .field,
1507-
.ui.form [class*="equal width"].fields > .field {
1508-
width: 100%;
1509-
flex: 1 1 auto;
1510-
}
1511-
15121502
/*--------------------
15131503
Inline Fields
15141504
---------------------*/

web_src/fomantic/build/components/modal.css

+2-7
Original file line numberDiff line numberDiff line change
@@ -116,12 +116,7 @@
116116
align-self: start;
117117
max-width: 100%;
118118
}
119-
.ui.modal > [class*="top aligned"] {
120-
align-self: start;
121-
}
122-
.ui.modal > [class*="middle aligned"] {
123-
align-self: center;
124-
}
119+
125120
.ui.modal > [class*="stretched"] {
126121
align-self: stretch;
127122
}
@@ -258,7 +253,7 @@
258253
padding: 1rem 0 !important;
259254
box-shadow: none;
260255
}
261-
256+
262257
/* Let Buttons Stack */
263258
.ui.modal > .actions {
264259
padding: 1rem 1rem 0rem !important;

0 commit comments

Comments
 (0)