Skip to content
This repository was archived by the owner on Jun 8, 2019. It is now read-only.
This repository was archived by the owner on Jun 8, 2019. It is now read-only.

ListPullRequestsOptions does not work? #161

Open
#162
Open
ListPullRequestsOptions does not work?#161
#162
Labels
kind/bug
@quantonganh

Description

@quantonganh
quantonganh
opened on Apr 19, 2019

go-sdk/gitea/pull.go

Line 77 in 7d954d7

return prs, c.getParsedResponse("GET", fmt.Sprintf("/repos/%s/%s/pulls", owner, repo), jsonHeader, bytes.NewReader(body), &prs)

How does this work?

go-sdk/gitea/gitea.go

Line 109 in 7d954d7

func (c *Client) getParsedResponse(method, path string, header http.Header, body io.Reader, obj interface{}) error {

go-sdk/gitea/gitea.go

Line 73 in 7d954d7

func (c *Client) getResponse(method, path string, header http.Header, body io.Reader) ([]byte, error) {

go-sdk/gitea/gitea.go

Line 55 in 7d954d7

func (c *Client) doRequest(method, path string, header http.Header, body io.Reader) (*http.Response, error) {

You passed body as a JSON to a GET request and expect it will be converted to a query string?

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions