Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.
This repository has been archived by the owner on May 1, 2023. It is now read-only.

NACK support #23

Open
Open
@cyphar

Description

@cyphar

Currently we only support two states:

  1. Not accepted, where not enough LGTMs have been received.
  2. Accepted, where >n LGTMs have been received and it's good to merge.

I think we should consider having another state:

  • Rejected or NACK'd, where a maintainer has said "No" to a change. Now, this will be a bit tricky to make configurable (purely because of how hard it is to specify what the maintainence politics of a project are in code) but there should be a way to make it so that a NACK can't be overlooked by a maintainer.

WDYT?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions