Possible misuse of unsafe.Pointer

[UserAB1236872]

I just ran go vet after the recent GC changes and got

gl.go:66 possible misuse of unsafe.Pointer

I haven't run into any issues, but I'm not familiar with how this package uses the ptr function so it may be looking into whether the GC changes may screw anything up.

[pwaller]

I can't tell, actually. The GC page sounds pretty unequivocal on that point, so maybe it is an abuse. But I'm not sure what the fix is.

[UserAB1236872]

It looks like they flat out consider the use of uintptr -> unsafe.Pointer spurious now. How much is that conversion used? How much would break if that case was removed?

[UserAB1236872]

Oh, I see, it allows callers to pass in a uintptr it doesn't look like it's used internally that way.

Since, as the changelog indicates, Go doesn't allow explicit *T -> uintptr conversion now.

http://play.golang.org/p/J1E16Wcngu

So given that's true, it should be safe as long as it's only used for pointers grabbed from C maybe?