Skip to content

Leaking sensitive data on span attributes #54

@ar-sematell

Description

@ar-sematell

Hello,

I noticed that the default behavior of this library is to add the query vars to the span attribute.
I know there is the option to use WithoutQueryVariables.
I think this is an insecure approach, as by default it potentially leaks variables and secrets to the open telemetry.

The most secure approach would be to invert the logic to WithQueryVariables, making the developer aware that if he wants the query variables, he would need to use this option, instead of the opposite: the developer is not aware, and the query variables are there.

Thanks for your attention!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions