Skip to content

Commit fde6084

Browse files
author
Vladimir Smirnov
committed
Update autogeneration for rewriteFunctions glue code to match same for functions
* This also makes linter happier
1 parent 66461e7 commit fde6084

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

expr/rewrite/glue.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@ type initFunc struct {
1717
}
1818

1919
func New(configs map[string]string) {
20-
funcs := make([]initFunc, 0, 2)
21-
22-
funcs = append(funcs, initFunc{name: "aboveSeries", order: aboveSeries.GetOrder(), f: aboveSeries.New})
23-
24-
funcs = append(funcs, initFunc{name: "applyByNode", order: applyByNode.GetOrder(), f: applyByNode.New})
20+
funcs := []initFunc{
21+
{name: "aboveSeries", order: aboveSeries.GetOrder(), f: aboveSeries.New},
22+
{name: "applyByNode", order: applyByNode.GetOrder(), f: applyByNode.New},
23+
}
2524

2625
sort.Slice(funcs, func(i, j int) bool {
2726
if funcs[i].order == interfaces.Any && funcs[j].order == interfaces.Last {

internal/generateRewriteFuncs/gen.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@ type initFunc struct {
5454
}
5555
5656
func New(configs map[string]string) {
57-
funcs := make([]initFunc, 0, %v)
58-
`, len(funcs))
59-
for _, m := range funcs {
60-
fmt.Fprintf(writer, `
61-
funcs = append(funcs, initFunc{name: "%s", order: %s.GetOrder(), f: %s.New})
62-
`, m, m, m)
57+
funcs := []initFunc{`)
58+
for _, m := range funcs {
59+
fmt.Fprintf(writer, `
60+
{name: "%s", order: %s.GetOrder(), f: %s.New},`, m, m, m)
61+
62+
}
6363

64+
fmt.Fprintln(writer, `
6465
}
6566
66-
fmt.Fprintln(writer, `
6767
sort.Slice(funcs, func(i, j int) bool {
6868
if funcs[i].order == interfaces.Any && funcs[j].order == interfaces.Last {
6969
return true

0 commit comments

Comments
 (0)