Ignore 'metric not found' if there are cached results from other targets#929
Open
teqwve wants to merge 1 commit into
Open
Ignore 'metric not found' if there are cached results from other targets#929teqwve wants to merge 1 commit into
teqwve wants to merge 1 commit into
Conversation
…ets. Before if there was a query with multiple targets that differ only in metrics that are missing a subsequent targets were treated as invalid because carbonapi was querying only for missing metrics and getting an error from zipper. E.g. a query: group(presentmetric,missingmetric) | min() group(presentmetric,othermissingmetric) | max() or a query: group(presentmetric,missingmetric) | min() group(presentmetric,missingmetric) | max() would return results only for the first target.
teqwve
force-pushed
the
fix-multi-target-missing-metrics
branch
from
a670119 to
dd80a87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
If there is a query with multiple targets that differ only in metrics that are missing a subsequent targets were treated as invalid because carbonapi was querying only for missing metrics and getting an error from zipper.
E.g. a query with targets:
or a query with targets:
returns results only for the first target. This fix uses cached results to determine whether the error should be ignored. It should fix #844