Merge pull request #816 from drawks/deepsource

Replace MD5 hashing in favor of xxh3

Author: deniszh

carbonserver/render.go

@@ -3,8 +3,6 @@ package carbonserver
 import (
 	"bytes"
 	"context"
-	"crypto/md5"
-	"encoding/hex"
 	"fmt"
 	"io"
 	"math"
@@ -25,6 +23,7 @@ import (
 	"go.uber.org/zap"
 
 	"github.com/go-graphite/carbonzipper/zipper/httpHeaders"
+	"github.com/go-graphite/go-carbon/helper"
 	"github.com/go-graphite/go-whisper"
 	grpcv2 "github.com/go-graphite/protocol/carbonapi_v2_grpc"
 	protov2 "github.com/go-graphite/protocol/carbonapi_v2_pb"
@@ -52,11 +51,6 @@ type timeRange struct {
 	until int32
 }
 
-func getMD5HashString(text string) string {
-	hash := md5.Sum([]byte(text))
-	return hex.EncodeToString(hash[:])
-}
-
 func getTargetNames(targets map[timeRange][]target) []string {
 	c := 0
 	for _, v := range targets {
@@ -295,8 +289,7 @@ func (listener *CarbonserverListener) getRenderCacheKeyAndSize(targets map[timeR
 	for tr, ts := range targets {
 		names := make([]string, 0, len(ts))
 		for _, t := range ts {
-			pathExpressionMD5 := getMD5HashString(t.PathExpression)
-			names = append(names, t.Name+"&"+pathExpressionMD5)
+			names = append(names, t.Name+"&"+strconv.FormatUint(helper.HashString(t.PathExpression), 16))
 		}
 		targetKeys = append(targetKeys, fmt.Sprintf("%s&%d&%d", strings.Join(names, "&"), tr.from, tr.until))
 	}

carbonserver/trie.go

@@ -1,7 +1,6 @@
 package carbonserver
 
 import (
-	"crypto/md5" // skipcq: GSC-G501
 	"errors"
 	"fmt"
 	"io"
@@ -2296,8 +2295,7 @@ func (*trieIndex) metricName(node *trieNode, name string) string {
 	// WHY: on linux, the maximum filename length is 255, keeping 5 here for
 	// file extension.
 	if len(name) >= 250 {
-		// skipcq: GSC-G401, GO-S1023
-		name = fmt.Sprintf("%s-%x", name[:(250-md5.Size*2-1)], md5.Sum([]byte(name)))
+		name = fmt.Sprintf("%.233s-%.16x", name, helper.HashString(name))
 	}
 	return prefix + name
 }