Remove stale goenv shims from v2 installations during upgrade to v3

Author: AdamDrewsTR

cmd/root.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"fmt"
 	"os"
+	"path/filepath"
 	"strings"
 
 	"github.com/go-nv/goenv/internal/cmdutil"
@@ -62,6 +63,17 @@ var RootCmd = &cobra.Command{
 		// Store updated context back to command
 		cmd.SetContext(ctx)
 
+		// Remove stale goenv shim left over from v2.
+		// v2's goenv-rehash bakes the Homebrew Cellar path into shims at creation
+		// time. After upgrading to v3, an old $GOENV_ROOT/shims/goenv may still
+		// point to a deleted Cellar path, shadowing the real v3 binary. v3 never
+		// creates a goenv shim (it skips itself in Rehash), so any shim present
+		// is stale and safe to remove.
+		goenvShim := filepath.Join(cfg.ShimsDir(), "goenv")
+		if _, err := os.Stat(goenvShim); err == nil {
+			_ = os.Remove(goenvShim)
+		}
+
 		// Propagate output options
 		utils.SetOutputOptions(NoColor, Plain)
 	},

install.sh

@@ -122,6 +122,17 @@ install_binary() {
     # Cleanup
     rm -rf "$tmp_dir"
 
+    # Remove stale goenv shim from v2 installations
+    # v2's goenv-rehash bakes the Homebrew Cellar path into shims at creation time.
+    # When upgrading to v3, the old shim at $GOENV_ROOT/shims/goenv may still point
+    # to a deleted Cellar path (e.g. /opt/homebrew/Cellar/goenv/2.2.38_1/libexec/goenv),
+    # which shadows the real v3 binary and causes "No such file or directory" errors.
+    if [ -f "$GOENV_ROOT/shims/goenv" ]; then
+        echo -e "${YELLOW}Removing stale goenv shim from previous installation...${NC}"
+        rm -f "$GOENV_ROOT/shims/goenv"
+        echo -e "${GREEN}✓ Stale shim removed${NC}"
+    fi
+    
     echo -e "${GREEN}✓ goenv installed successfully!${NC}"
 }
 

scripts/swap/main.go

@@ -407,6 +407,21 @@ Options:
 		swapGoenvBinary(target)
 	}
 
+	// Remove stale goenv shim from v2 that may shadow the new binary
+	goenvRoot := os.Getenv("GOENV_ROOT")
+	if goenvRoot == "" {
+		homeDir, _ := os.UserHomeDir()
+		goenvRoot = filepath.Join(homeDir, ".goenv")
+	}
+	staleShim := filepath.Join(goenvRoot, "shims", "goenv")
+	if utils.FileExists(staleShim) {
+		if err := os.Remove(staleShim); err == nil {
+			success("Removed stale goenv shim from " + staleShim)
+		} else {
+			warn(fmt.Sprintf("Could not remove stale shim %s: %v", staleShim, err))
+		}
+	}
+
 	fmt.Println()
 	success("Switch successful!")
 	warn("IMPORTANT: Reload your shell before testing:")