Commit 30eab56
authored
Don't suggest adding GOROOT/bin and GOPATH/bin to the PATH. (#463)
The installation instructions say to make the shell init script execute the
output of `goenv init -`. That output contains this among other things:
```
export PATH="${GOENV_ROOT}/shims:${PATH}"
```
The main point of that line is to make the `go` command resolve to
`$GOENV_ROOT/shims/go` such that `goenv` has control over the default `go`.
The installation instructions later say to add this after the eval in order to
let "goenv manage GOPATH and GOROOT":
```
export PATH="$GOROOT/bin:$PATH"
export PATH="$PATH:$GOPATH/bin"
```
This effectively overrides the first line as `$GOROOT/bin` is also expected to
contain a `go` binary. However that binary is not controlled by `goenv`.
Furthermore AFAICT these two lines do not make "goenv manage GOPATH and GOROOT".
This has confused at least [one other user](#186 (comment)).
This change removes the section about GOROOT and GOPATH as I don't see why it
would belong in the goenv installation instructions.1 parent db10fc4 commit 30eab56
1 file changed
Lines changed: 3 additions & 26 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
37 | 37 | | |
38 | 38 | | |
39 | 39 | | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | 40 | | |
62 | | - | |
| 41 | + | |
63 | 42 | | |
64 | 43 | | |
65 | 44 | | |
66 | 45 | | |
67 | | - | |
| 46 | + | |
68 | 47 | | |
69 | 48 | | |
70 | 49 | | |
71 | 50 | | |
72 | 51 | | |
73 | 52 | | |
74 | | - | |
| 53 | + | |
75 | 54 | | |
76 | 55 | | |
77 | 56 | | |
| |||
82 | 61 | | |
83 | 62 | | |
84 | 63 | | |
85 | | - | |
86 | | - | |
87 | 64 | | |
88 | 65 | | |
89 | 66 | | |
| |||
0 commit comments