|
| 1 | +package migration |
| 2 | + |
| 3 | +import ( |
| 4 | + "os" |
| 5 | + "path/filepath" |
| 6 | + "testing" |
| 7 | +) |
| 8 | + |
| 9 | +func TestRemoveStaleV2Shim(t *testing.T) { |
| 10 | + // Create a temporary directory for testing |
| 11 | + tmpDir, err := os.MkdirTemp("", "goenv-test-*") |
| 12 | + if err != nil { |
| 13 | + t.Fatalf("Failed to create temp dir: %v", err) |
| 14 | + } |
| 15 | + defer os.RemoveAll(tmpDir) |
| 16 | + |
| 17 | + shimsDir := filepath.Join(tmpDir, "shims") |
| 18 | + if err := os.MkdirAll(shimsDir, 0755); err != nil { |
| 19 | + t.Fatalf("Failed to create shims dir: %v", err) |
| 20 | + } |
| 21 | + |
| 22 | + t.Run("removes v2 shim with forward slash", func(t *testing.T) { |
| 23 | + // Create a v2 shim with forward slash |
| 24 | + shimPath := filepath.Join(shimsDir, "goenv") |
| 25 | + v2Content := `#!/usr/bin/env bash |
| 26 | +exec "/opt/homebrew/Cellar/goenv/2.2.38_1/libexec/goenv" "$@" |
| 27 | +` |
| 28 | + if err := os.WriteFile(shimPath, []byte(v2Content), 0755); err != nil { |
| 29 | + t.Fatalf("Failed to create shim: %v", err) |
| 30 | + } |
| 31 | + |
| 32 | + removed, err := RemoveStaleV2Shim(shimsDir) |
| 33 | + if err != nil { |
| 34 | + t.Errorf("Unexpected error: %v", err) |
| 35 | + } |
| 36 | + if !removed { |
| 37 | + t.Error("Expected shim to be removed") |
| 38 | + } |
| 39 | + if _, err := os.Stat(shimPath); !os.IsNotExist(err) { |
| 40 | + t.Error("Shim file should not exist") |
| 41 | + } |
| 42 | + }) |
| 43 | + |
| 44 | + t.Run("removes v2 shim with backslash", func(t *testing.T) { |
| 45 | + // Create a v2 shim with backslash (Windows-style) |
| 46 | + shimPath := filepath.Join(shimsDir, "goenv") |
| 47 | + v2Content := `@echo off |
| 48 | +"C:\Program Files\goenv\libexec\goenv" %* |
| 49 | +` |
| 50 | + if err := os.WriteFile(shimPath, []byte(v2Content), 0755); err != nil { |
| 51 | + t.Fatalf("Failed to create shim: %v", err) |
| 52 | + } |
| 53 | + |
| 54 | + removed, err := RemoveStaleV2Shim(shimsDir) |
| 55 | + if err != nil { |
| 56 | + t.Errorf("Unexpected error: %v", err) |
| 57 | + } |
| 58 | + if !removed { |
| 59 | + t.Error("Expected shim to be removed") |
| 60 | + } |
| 61 | + if _, err := os.Stat(shimPath); !os.IsNotExist(err) { |
| 62 | + t.Error("Shim file should not exist") |
| 63 | + } |
| 64 | + }) |
| 65 | + |
| 66 | + t.Run("does not remove non-v2 shim", func(t *testing.T) { |
| 67 | + // Create a non-v2 shim |
| 68 | + shimPath := filepath.Join(shimsDir, "goenv") |
| 69 | + v3Content := `#!/usr/bin/env bash |
| 70 | +# This is a v3 shim |
| 71 | +exec "goenv" "$@" |
| 72 | +` |
| 73 | + if err := os.WriteFile(shimPath, []byte(v3Content), 0755); err != nil { |
| 74 | + t.Fatalf("Failed to create shim: %v", err) |
| 75 | + } |
| 76 | + |
| 77 | + removed, err := RemoveStaleV2Shim(shimsDir) |
| 78 | + if err != nil { |
| 79 | + t.Errorf("Unexpected error: %v", err) |
| 80 | + } |
| 81 | + if removed { |
| 82 | + t.Error("Expected shim to NOT be removed") |
| 83 | + } |
| 84 | + if _, err := os.Stat(shimPath); os.IsNotExist(err) { |
| 85 | + t.Error("Shim file should still exist") |
| 86 | + } |
| 87 | + }) |
| 88 | + |
| 89 | + t.Run("handles missing shim file", func(t *testing.T) { |
| 90 | + // Ensure no shim exists |
| 91 | + shimPath := filepath.Join(shimsDir, "goenv") |
| 92 | + os.Remove(shimPath) |
| 93 | + |
| 94 | + removed, err := RemoveStaleV2Shim(shimsDir) |
| 95 | + if err != nil { |
| 96 | + t.Errorf("Unexpected error: %v", err) |
| 97 | + } |
| 98 | + if removed { |
| 99 | + t.Error("Expected no removal when file doesn't exist") |
| 100 | + } |
| 101 | + }) |
| 102 | + |
| 103 | + t.Run("returns error when removal fails", func(t *testing.T) { |
| 104 | + // This test is platform-dependent and may not work in all environments |
| 105 | + // Skip if we can't create a read-only directory |
| 106 | + shimPath := filepath.Join(shimsDir, "goenv") |
| 107 | + v2Content := `#!/usr/bin/env bash |
| 108 | +exec "/opt/homebrew/Cellar/goenv/2.2.38_1/libexec/goenv" "$@" |
| 109 | +` |
| 110 | + if err := os.WriteFile(shimPath, []byte(v2Content), 0755); err != nil { |
| 111 | + t.Fatalf("Failed to create shim: %v", err) |
| 112 | + } |
| 113 | + |
| 114 | + // Make directory read-only (Unix-like systems) |
| 115 | + if err := os.Chmod(shimsDir, 0555); err != nil { |
| 116 | + t.Skip("Cannot test permission error on this platform") |
| 117 | + } |
| 118 | + defer os.Chmod(shimsDir, 0755) // Restore permissions |
| 119 | + |
| 120 | + removed, err := RemoveStaleV2Shim(shimsDir) |
| 121 | + if err == nil { |
| 122 | + t.Error("Expected error when removal fails") |
| 123 | + } |
| 124 | + if removed { |
| 125 | + t.Error("Should not report as removed when error occurs") |
| 126 | + } |
| 127 | + }) |
| 128 | +} |
| 129 | + |
| 130 | +func TestV2ShimPattern(t *testing.T) { |
| 131 | + tests := []struct { |
| 132 | + name string |
| 133 | + content string |
| 134 | + matches bool |
| 135 | + }{ |
| 136 | + { |
| 137 | + name: "forward slash", |
| 138 | + content: `exec "/opt/homebrew/Cellar/goenv/2.2.38_1/libexec/goenv" "$@"`, |
| 139 | + matches: true, |
| 140 | + }, |
| 141 | + { |
| 142 | + name: "backslash", |
| 143 | + content: `"C:\Program Files\goenv\libexec\goenv" %*`, |
| 144 | + matches: true, |
| 145 | + }, |
| 146 | + { |
| 147 | + name: "no match", |
| 148 | + content: `exec "goenv" "$@"`, |
| 149 | + matches: false, |
| 150 | + }, |
| 151 | + { |
| 152 | + name: "libexec only", |
| 153 | + content: `exec "/usr/local/libexec/goenv-other" "$@"`, |
| 154 | + matches: false, |
| 155 | + }, |
| 156 | + { |
| 157 | + name: "goenv only", |
| 158 | + content: `exec "/usr/local/bin/goenv" "$@"`, |
| 159 | + matches: false, |
| 160 | + }, |
| 161 | + } |
| 162 | + |
| 163 | + for _, tt := range tests { |
| 164 | + t.Run(tt.name, func(t *testing.T) { |
| 165 | + matches := V2ShimPattern.MatchString(tt.content) |
| 166 | + if matches != tt.matches { |
| 167 | + t.Errorf("Expected match=%v, got match=%v for content: %s", tt.matches, matches, tt.content) |
| 168 | + } |
| 169 | + }) |
| 170 | + } |
| 171 | +} |
0 commit comments