Fix goenv alias regression - respect explicit version folder names (#495)

* Initial plan

* Fix variable reference bug in goenv-version-name and goenv-which

Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>

* Fix goenv-installed to respect exact version folders before resolving

Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ChronosMasterOfAllTime <28963807+ChronosMasterOfAllTime@users.noreply.github.com>

Author: Copilot

libexec/goenv-installed

@@ -87,6 +87,12 @@ if [ "$version" = "latest" ]; then
   fi
 fi
 
+# Check if exact version folder exists first (e.g., user has an alias folder like "1.21")
+if [ -d "${GOENV_ROOT}/versions/${version}" ]; then
+  echo "$version"
+  exit 0
+fi
+
 # Check version=1 (major without minor and patch) => 1.23.4 (latest major version)
 # Or version=23 (minor without major and patch) => 1.23.4 (latest patch version)
 # Or version=23rc1 (minor with release candidate) => 1.23rc2 (latest release candidate version)

libexec/goenv-version-name

@@ -26,7 +26,7 @@ version_exists() {
   local input_version="$1"
   local use_go_mod="$2"
 
-  if [[ -n use_go_mod ]] && [[ -d ${GOENV_ROOT}/versions ]] && grep -q -E "^[0-9]+\.[0-9]+\.?[0-9]*(\s*)$" <<<${input_version}; then
+  if [[ -n "$use_go_mod" ]] && [[ -d ${GOENV_ROOT}/versions ]] && grep -q -E "^[0-9]+\.[0-9]+\.?[0-9]*(\s*)$" <<<${input_version}; then
     OLDIFS="$IFS"
     IFS=$'\n'
     local version_regex=$(echo ${input_version} | sed s/\\./\\\\./)

libexec/goenv-which

@@ -63,7 +63,7 @@ version_exists() {
   local input_version="$1"
   local use_go_mod="$2"
 
-  if [[ -n use_go_mod ]] && [[ -d ${GOENV_ROOT}/versions ]] && grep -q -E "^[0-9]+\.[0-9]+(\s*)$" <<<${input_version}; then
+  if [[ -n "$use_go_mod" ]] && [[ -d ${GOENV_ROOT}/versions ]] && grep -q -E "^[0-9]+\.[0-9]+(\s*)$" <<<${input_version}; then
     OLDIFS="$IFS"
     IFS=$'\n'
     local version_regex=$(echo ${input_version} | sed s/\\./\\\\./)

test/goenv-installed.bats

@@ -101,3 +101,26 @@ OUT
   run goenv-installed 1.2.4
   assert_failure "goenv: version '1.2.4' not installed"
 }
+
+@test "respects exact version folder when alias folder exists" {
+  # User has an alias folder like "1.21" that contains go 1.21.13
+  mkdir -p "${GOENV_ROOT}/versions/1.21"
+  run goenv-installed 1.21
+  assert_success "1.21"
+}
+
+@test "uses exact alias folder even when full version folder exists" {
+  # User has both an alias folder and the full version folder
+  mkdir -p "${GOENV_ROOT}/versions/1.21"
+  mkdir -p "${GOENV_ROOT}/versions/1.21.13"
+  run goenv-installed 1.21
+  assert_success "1.21"
+}
+
+@test "resolves to latest patch when no exact alias folder exists" {
+  # Only full version folders exist, no alias
+  mkdir -p "${GOENV_ROOT}/versions/1.20.5"
+  mkdir -p "${GOENV_ROOT}/versions/1.20.8"
+  run goenv-installed 1.20
+  assert_success "1.20.8"
+}

test/goenv-version-name.bats

@@ -121,3 +121,22 @@ OUT
 
   assert_success "1.10.3"
 }
+
+@test "respects version set by alias folder name" {
+  # Simulate installing go 1.21.13 aliased as 1.21
+  create_version "1.21"
+  echo "1.21" > '.go-version'
+  run goenv-version-name
+
+  assert_success "1.21"
+}
+
+@test "respects version set by alias folder name even when full version folder exists" {
+  # User has both an alias folder and the full version folder
+  create_version "1.21"
+  create_version "1.21.13"
+  echo "1.21" > '.go-version'
+  run goenv-version-name
+
+  assert_success "1.21"
+}