From dff9cdb246a39b89821bc526cc36a1eeb5103629 Mon Sep 17 00:00:00 2001
From: Adrien Kunysz <adrien.kunysz@swisstopo.ch>
Date: Tue, 1 Jul 2025 15:34:14 +0200
Subject: [PATCH] Don't suggest adding GOROOT/bin and GOPATH/bin to the PATH.

The installation instructions say to make the shell init script execute the
output of `goenv init -`. That output contains this among other things:
```
export PATH="${GOENV_ROOT}/shims:${PATH}"
```
The main point of that line is to make the `go` command resolve to
`$GOENV_ROOT/shims/go` such that `goenv` has control over the default `go`.

The installation instructions later say to add this after the eval in order to
let "goenv manage GOPATH and GOROOT":
```
export PATH="$GOROOT/bin:$PATH"
export PATH="$PATH:$GOPATH/bin"
```

This effectively overrides the first line as `$GOROOT/bin` is also expected to
contain a `go` binary. However that binary is not controlled by `goenv`.
Furthermore AFAICT these two lines do not make "goenv manage GOPATH and GOROOT".

This has confused at least [one other user](https://github.com/go-nv/goenv/issues/186#issuecomment-2623334453).

This change removes the section about GOROOT and GOPATH as I don't see why it
would belong in the goenv installation instructions.
---
 INSTALL.md | 29 +++--------------------------
 1 file changed, 3 insertions(+), 26 deletions(-)

diff --git a/INSTALL.md b/INSTALL.md
index 1cb34b7a..14043b3a 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -37,41 +37,20 @@ easy to fork and contribute any changes back upstream.
     may observe strange behaviour, such as `goenv` getting into an infinite loop.
     See pyenv's issue [#264](https://github.com/pyenv/pyenv/issues/264) for details.
     
-4. **If you want  `goenv` to manage `GOPATH` and `GOROOT` (recommended)**, 
-  add `GOPATH` and `GOROOT` to your shell **after `eval "$(goenv init -)"`**.
-  
-       echo 'export PATH="$GOROOT/bin:$PATH"' >> ~/.bash_profile
-       echo 'export PATH="$PATH:$GOPATH/bin"' >> ~/.bash_profile
-        
-    **Zsh note**: Modify your `~/.zshenv` or `~/.zshrc` file instead of `~/.bash_profile`.
-    
-    **Ubuntu note**: Modify your `~/.bashrc` file instead of `~/.bash_profile`.
-
-    **General warning**: There are some systems where the `BASH_ENV` variable is configured
-    to point to `.bashrc`. On such systems you should almost certainly put the abovementioned line
-    `eval "$(goenv init -)` into `.bash_profile`, and **not** into `.bashrc`. Otherwise you
-    may observe strange behaviour, such as `goenv` getting into an infinite loop.
-    See pyenv's issue [#264](https://github.com/pyenv/pyenv/issues/264) for details.
-
-    **Security warning**: You likely want to keep $GOPATH/bin at the end
-    of your $PATH as shown above, rather than at the beginning.  See
-    [#99](https://github.com/go-nv/goenv/issues/99) for details and
-    discussion.
-  
 
-5. **Restart your shell so the path changes take effect.**
+4. **Restart your shell so the path changes take effect.**
    You can now begin using goenv.
 
        exec $SHELL
 
-6. **Install Go versions into `$GOENV_ROOT/versions`.**
+5. **Install Go versions into `$GOENV_ROOT/versions`.**
    For example, to download and install Go 1.12.0, run:
 
        goenv install 1.12.0
 
    **NOTE:** It downloads and places the prebuilt Go binaries provided by Google.
 
-7. **Set goenv global version.**
+6. **Set goenv global version.**
    For example, to set the version to Go 1.12.0, run:
 
        goenv global 1.12.0
@@ -82,8 +61,6 @@ An example `.zshrc` that is properly configured may look like
 export GOENV_ROOT="$HOME/.goenv"
 export PATH="$GOENV_ROOT/bin:$PATH"
 eval "$(goenv init -)"
-export PATH="$GOROOT/bin:$PATH"
-export PATH="$PATH:$GOPATH/bin"
 ```
    
 ## via ZPlug plugin manager for Zsh