feat(enhancement): use request hostname if path is empty or '/' for save response (#948)

Author: jeevatkm

client.go

@@ -1791,6 +1791,7 @@ func (c *Client) IsSaveResponse() bool {
 //   - [Request.SetOutputFileName]
 //   - Content-Disposition header
 //   - Request URL using [path.Base]
+//   - Request URL hostname if path is empty or "/"
 //
 // It can be overridden at request level, see [Request.SetSaveResponse]
 func (c *Client) SetSaveResponse(save bool) *Client {

middleware.go

@@ -538,6 +538,8 @@ func AutoParseResponseMiddleware(c *Client, res *Response) (err error) {
 	return
 }
 
+var hostnameReplacer = strings.NewReplacer(":", "_", ".", "_")
+
 // SaveToFileResponseMiddleware method used to write HTTP response body into
 // file. The filename is determined in the following order -
 //   - [Request.SetOutputFileName]
@@ -557,8 +559,12 @@ func SaveToFileResponseMiddleware(c *Client, res *Response) error {
 			}
 		}
 		if isStringEmpty(file) {
-			urlPath, _ := url.Parse(res.Request.URL)
-			file = path.Base(urlPath.Path)
+			rURL, _ := url.Parse(res.Request.URL)
+			if isStringEmpty(rURL.Path) || rURL.Path == "/" {
+				file = hostnameReplacer.Replace(rURL.Host)
+			} else {
+				file = path.Base(rURL.Path)
+			}
 		}
 	}
 

request.go

@@ -675,6 +675,7 @@ func (r *Request) SetOutputFileName(file string) *Request {
 //   - [Request.SetOutputFileName]
 //   - Content-Disposition header
 //   - Request URL using [path.Base]
+//   - Request URL hostname if path is empty or "/"
 //
 // It overrides the value set at the client instance level, see [Client.SetSaveResponse]
 func (r *Request) SetSaveResponse(save bool) *Request {

request_test.go

@@ -1406,6 +1406,13 @@ func TestRequestSaveResponse(t *testing.T) {
 		assertNil(t, err)
 	})
 
+	t.Run("empty path", func(t *testing.T) {
+		_, err := c.R().
+			SetSaveResponse(true).
+			Get(ts.URL)
+		assertError(t, err)
+	})
+
 }
 
 func TestContextInternal(t *testing.T) {