fix bot detection

ysmood · ysmood · commit a68be36e4e66 · 2023-07-07T11:14:45.000+08:00
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -20,4 +20,4 @@ jobs:
 
       - run: go run github.com/ysmood/golangci-lint@latest
 
-      - run: go test -coverprofile=coverage.out ./...
+      - run: go test ./...
diff --git a/service.go b/service.go
@@ -33,7 +33,7 @@ func New(addr, target string) *Bartender {
 }
 
 func (b *Bartender) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	if r.Method == http.MethodGet && r.Header.Get("Accept-Language") != "" {
+	if r.Method == http.MethodGet && r.Header.Get("Accept-Language") == "" {
 		b.RenderPage(w, r)
 
 		return
diff --git a/service_test.go b/service_test.go
@@ -27,12 +27,14 @@ func TestBasic(t *testing.T) {
 	proxy.Mux.HandleFunc("/", bt.ServeHTTP)
 
 	{
-		res := g.Req("", proxy.URL("/test?q=ok"))
+		// browser
+		res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})
 		g.Has(res.String(), "<body></body>")
 	}
 
 	{
-		res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})
+		// web crawler
+		res := g.Req("", proxy.URL("/test?q=ok"))
 		g.Has(res.String(), "/test?q=ok")
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -20,4 +20,4 @@ jobs:`
`20`	`20`
`21`	`21`	`- run: go run github.com/ysmood/golangci-lint@latest`
`22`	`22`
`23`		`- - run: go test -coverprofile=coverage.out ./...`
	`23`	`+ - run: go test ./...`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func New(addr, target string) *Bartender {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`func (b Bartender) ServeHTTP(w http.ResponseWriter, r http.Request) {`
`36`		`- if r.Method == http.MethodGet && r.Header.Get("Accept-Language") != "" {`
	`36`	`+ if r.Method == http.MethodGet && r.Header.Get("Accept-Language") == "" {`
`37`	`37`	`b.RenderPage(w, r)`
`38`	`38`
`39`	`39`	`return`
Original file line number	Diff line number	Diff line change
`@@ -27,12 +27,14 @@ func TestBasic(t *testing.T) {`
`27`	`27`	`proxy.Mux.HandleFunc("/", bt.ServeHTTP)`
`28`	`28`
`29`	`29`	`{`
`30`		`- res := g.Req("", proxy.URL("/test?q=ok"))`
	`30`	`+ // browser`
	`31`	`+ res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})`
`31`	`32`	`g.Has(res.String(), "<body></body>")`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`{`
`35`		`- res := g.Req("", proxy.URL("/test?q=ok"), http.Header{"Accept-Language": {"en"}})`
	`36`	`+ // web crawler`
	`37`	`+ res := g.Req("", proxy.URL("/test?q=ok"))`
`36`	`38`	`g.Has(res.String(), "/test?q=ok")`
`37`	`39`	`}`
`38`	`40`	`}`