New release candidate: v1.5.5-rc.1

[fmartingr]

Hello everyone!

I have cut a new release candidate with a few changes that had been on master for some time: v1.5.5-rc.1.

Feel free to download and try it out for a while, and if you experience any issues report them so we can fix those before the final release.

Huge thanks to all contributors!

Changes

Features

• feat: add SHIORI_PG_SSLMODE by @refi64 in feat: add SHIORI_PG_SSLMODE #536
• feat: Initial Ebook support by @Monirzadeh in Initial Ebook support #623
• feat: improve bookmark image detection by @Katarn in feat: improve bookmark image detection #554
• feat: Add log args for root command by @chain710 in Add log args for root command #565

Fixes

• fix: Use UTC for cookie expiry date in backend by @MoX46 in Use UTC for cookie expiry date in backend #566
• fix: browser ext cannot archive and update bookmark. by @IvanLi-CN in fix: browser ext cannot archive and update bookmark. #560
• fix(frontend): prevent archive header covering up the archive content by @sdvcrx in fix(frontend): prevent archive header covering up the archive content #562
• fix direction in RTL language by @Monirzadeh in fix direction in RTL language #615
• fix(log): record user real ip from headers by @Tomilla in fix(log): record user real ip from headers #603
• fix: thumb image will be not accesable anymore if it is private [Security] Thumbnails of private bookmarks are accessible without authentication #578 by @Monirzadeh in thumb image will be not accesable anymore if it is private fix #578 #627
• fix: prevent bookmark overwrite on archive download by @fmartingr in fix: prevent bookmark overwrite on archive download #636

Dependencies & CI

• Update dependencies by @fmartingr
  • Update dependencies #616
  • deps: update direct deps #567
• deps: update to go 1.20 + dependencies. Fixes CI by @fmartingr in deps: update to go 1.20 + dependencies. Fixes CI #628

[omnisci3nce]

Thanks for keeping this project going. Awesome work.

[blogbourri]

When I updated my docker install, the update broke it so I couldn't login, giving an "sql: no rows in result set (500)" error.

[fmartingr]

From which version did you upgrade? Where do you have your shiori data folder?

I updated my production shiori from 1.5.4 without issues.

[blogbourri]

from 1.5.4, i was just using the sqlite database with i think default settings. i got impatient and wiped the install after (was meaning to switch over to mysql anyways), so unfortunately i can't go back and figure out what caused it. if it doesn't happen for anyone else might have been a configuration error on my end (pretty new to self-hosting). i did run into a single bug for the ebook export, i'll do a proper bug report for that one in a bit. very excited to have a working ebook export, and it worked great for all but one archive.

[fmartingr]

How do you create the container? Did you delete it before the upgrade you say?

I cant guarantee that no bugs are present, but upgrading should be non-destructive, since any database error stops the application from running before anything gets committed to disk.

My upgrade path was the same as yours (same database as well). I plan to have proper install/upgrade instructions, along with a backup reminder as well. I hope you didnt lose many data. The other person I recall had a similar issue, his database was stored on a different path. #291

[blogbourri]

The upgrade when I had the error was handled by watchtower, which should exactly recreate all the same settings as the prior install. I did lose all my bookmarks, slight bummer. I probably could have recovered them if I'd been patient enough to try and figure out what happened, so that's partially on me.

Thinking about it, it could have just been because the database got wiped when the upgrade happened, if it was stored in the same directory, so that would probably be a configuration error on my end? I never figured out where the database was stored before.

[fmartingr]

Im not familiar with watchtower, but the only thing that comes to mind is that it didn't create a volume for the data shiori stores. Using an ephemeral volume would mean that any image upgrade (or container restart) would wipe the database.

[eitau]

Heads up: title is never retrieved
https://github.com/go-shiori/shiori/blob/v1.5.5-rc.1/internal/webserver/handler-api.go#L320-L322

// Make sure bookmark's title not empty
if book.Title == "" {
    book.Title = book.URL
}
// ^ because if this
// …
        bookmark, err := downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                                   ^ it's always non-empty
// …
    book, err = downloadBookmarkContent(book, h.DataDir, r, book.Title != "", book.Excerpt != "")
//                                                          ^ it's always non-empty