This repository was archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
Let quote optional #552
Closed
Let quote optional #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wiil be a solution to temporarily resolve #265 |
|
Will also be a solution to temporarily resolve #336 |
lunny
force-pushed
the
lunny/option_quote
branch
from
9edd2e3 to
91e61f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #552 +/- ##
=======================================
Coverage 49.65% 49.65%
=======================================
Files 33 33
Lines 7016 7016
=======================================
Hits 3484 3484
Misses 3065 3065
Partials 467 467
Continue to review full report at Codecov.
|
|
This PR introduces a new parameter QuoteMode, now there are 3 values, QuoteAddAlways, QuoteNoAdd, QuoteAddReserved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
will fix #543