web: Tidy error checking behavior.

Author: GirlBossRush

web/src/admin/applications/wizard/steps/ak-application-wizard-submit-step.ts

@@ -4,6 +4,7 @@ import { EVENT_REFRESH } from "@goauthentik/common/constants";
 import { parseAPIResponseError } from "@goauthentik/common/errors/network";
 import { WizardNavigationEvent } from "@goauthentik/components/ak-wizard/events.js";
 import { type WizardButton } from "@goauthentik/components/ak-wizard/types";
+import { showAPIErrorMessage } from "@goauthentik/elements/messages/MessageContainer";
 import { CustomEmitterElement } from "@goauthentik/elements/utils/eventEmitter";
 import { P, match } from "ts-pattern";
 
@@ -30,10 +31,15 @@ import {
     type TransactionApplicationRequest,
     type TransactionApplicationResponse,
     type TransactionPolicyBindingRequest,
+    instanceOfValidationError,
 } from "@goauthentik/api";
 
 import { ApplicationWizardStep } from "../ApplicationWizardStep.js";
-import { ApplicationTransactionValidationError, OneOfProvider } from "../types.js";
+import {
+    ApplicationTransactionValidationError,
+    OneOfProvider,
+    isApplicationTransactionValidationError,
+} from "../types.js";
 import { providerRenderers } from "./SubmitStepOverviewRenderers.js";
 
 const _submitStates = ["reviewing", "running", "submitted"] as const;
@@ -140,25 +146,35 @@ export class ApplicationWizardSubmitStep extends CustomEmitterElement(Applicatio
                 this.state = "submitted";
             })
 
-            .catch(async (resolution) => {
-                const errors =
-                    await parseAPIResponseError<ApplicationTransactionValidationError>(resolution);
+            .catch(async (error) => {
+                const parsedError = await parseAPIResponseError(error);
+
+                if (!instanceOfValidationError(parsedError)) {
+                    showAPIErrorMessage(parsedError);
+
+                    return;
+                }
+
+                if (isApplicationTransactionValidationError(parsedError)) {
+                    // THIS is a really gross special case; if the user is duplicating the name of an existing provider, the error appears on the `app` (!) error object.
+                    // We have to move that to the `provider.name` error field so it shows up in the right place.
+                    if (Array.isArray(parsedError.app?.provider)) {
+                        const providerError = parsedError.app.provider;
 
-                // THIS is a really gross special case; if the user is duplicating the name of an existing provider, the error appears on the `app` (!) error object.
-                // We have to move that to the `provider.name` error field so it shows up in the right place.
-                if (Array.isArray(errors?.app?.provider)) {
-                    const providerError = errors.app.provider;
-                    errors.provider = errors.provider ?? {};
-                    errors.provider.name = providerError;
+                        parsedError.provider = {
+                            ...parsedError.provider,
+                            name: providerError,
+                        };
 
-                    delete errors.app.provider;
+                        delete parsedError.app.provider;
 
-                    if (Object.keys(errors.app).length === 0) {
-                        delete errors.app;
+                        if (Object.keys(parsedError.app).length === 0) {
+                            delete parsedError.app;
+                        }
                     }
                 }
 
-                this.handleUpdate({ errors });
+                this.handleUpdate({ errors: parsedError });
                 this.state = "reviewing";
             });
     }

web/src/admin/applications/wizard/types.ts

@@ -1,5 +1,3 @@
-import { APIError } from "@goauthentik/common/errors/network";
-
 import {
     type ApplicationRequest,
     type LDAPProviderRequest,
@@ -36,15 +34,14 @@ export interface ApplicationTransactionValidationError extends ValidationError {
     app?: ValidationRecord;
     provider?: ValidationRecord;
     bindings?: ValidationRecord;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    detail?: any;
+    detail?: unknown;
 }
 
 /**
  * Type-guard to determine if an API response is shaped like an {@linkcode ApplicationTransactionValidationError}.
  */
 export function isApplicationTransactionValidationError(
-    error: APIError,
+    error: ValidationError,
 ): error is ApplicationTransactionValidationError {
     if ("app" in error) return true;
     if ("provider" in error) return true;