fix: allow setting different default col for checkSort

Author: LuccaBitfly

backend/pkg/api/enums/notifications_enums.go

@@ -26,7 +26,7 @@ func (NotificationDashboardsColumn) NewFromString(s string) NotificationDashboar
 	switch s {
 	case "chain_id":
 		return NotificationDashboardChainId
-	case "epoch":
+	case "", "epoch":
 		return NotificationDashboardEpoch
 	case "dashboard_name", "dashboard_id": // accepting id for frontend
 		return NotificationDashboardDashboardName
@@ -98,7 +98,7 @@ func (NotificationMachinesColumn) NewFromString(s string) NotificationMachinesCo
 		return NotificationMachineThreshold
 	case "event_type":
 		return NotificationMachineEventType
-	case "timestamp":
+	case "", "timestamp":
 		return NotificationMachineTimestamp
 	default:
 		return NotificationMachinesColumn(-1)
@@ -157,7 +157,7 @@ func (NotificationClientsColumn) NewFromString(s string) NotificationClientsColu
 	switch s {
 	case "client_name":
 		return NotificationClientName
-	case "timestamp":
+	case "", "timestamp":
 		return NotificationClientTimestamp
 	default:
 		return NotificationClientsColumn(-1)
@@ -203,7 +203,7 @@ func (c NotificationRocketPoolColumn) Int() int {
 
 func (NotificationRocketPoolColumn) NewFromString(s string) NotificationRocketPoolColumn {
 	switch s {
-	case "timestamp":
+	case "", "timestamp":
 		return NotificationRocketPoolTimestamp
 	case "event_type":
 		return NotificationRocketPoolEventType
@@ -243,7 +243,7 @@ func (c NotificationNetworksColumn) Int() int {
 
 func (NotificationNetworksColumn) NewFromString(s string) NotificationNetworksColumn {
 	switch s {
-	case "timestamp":
+	case "", "timestamp":
 		return NotificationNetworkTimestamp
 	case "event_type":
 		return NotificationNetworkEventType
@@ -294,7 +294,7 @@ func (c NotificationSettingsDashboardColumn) Int() int {
 
 func (NotificationSettingsDashboardColumn) NewFromString(s string) NotificationSettingsDashboardColumn {
 	switch s {
-	case "dashboard_name", "dashboard_id":
+	case "", "dashboard_name", "dashboard_id":
 		return NotificationSettingsDashboardDashboardName
 	case "group_name":
 		return NotificationSettingsDashboardGroupName

backend/pkg/api/enums/validator_dashboard_enums.go

@@ -27,7 +27,7 @@ func (c VDBSummaryColumn) Int() int {
 
 func (VDBSummaryColumn) NewFromString(s string) VDBSummaryColumn {
 	switch s {
-	case "group_id":
+	case "", "group_id":
 		return VDBSummaryGroup
 	case "validators":
 		return VDBSummaryValidators
@@ -77,7 +77,7 @@ func (c VDBRewardsColumn) Int() int {
 
 func (VDBRewardsColumn) NewFromString(s string) VDBRewardsColumn {
 	switch s {
-	case "epoch":
+	case "", "epoch":
 		return VDBRewardEpoch
 	default:
 		return VDBRewardsColumn(-1)
@@ -108,7 +108,7 @@ func (c VDBDutiesColumn) Int() int {
 
 func (VDBDutiesColumn) NewFromString(s string) VDBDutiesColumn {
 	switch s {
-	case "validator":
+	case "", "validator":
 		return VDBDutyValidator
 	case "reward":
 		return VDBDutyReward
@@ -148,7 +148,7 @@ func (VDBBlocksColumn) NewFromString(s string) VDBBlocksColumn {
 	switch s {
 	case "proposer":
 		return VDBBlockProposer
-	case "slot":
+	case "", "slot":
 		return VDBBlockSlot
 	case "block":
 		return VDBBlockBlock
@@ -221,7 +221,7 @@ func (VDBWithdrawalsColumn) NewFromString(s string) VDBWithdrawalsColumn {
 	switch s {
 	case "epoch":
 		return VDBWithdrawalEpoch
-	case "slot":
+	case "", "slot":
 		return VDBWithdrawalSlot
 	case "index":
 		return VDBWithdrawalIndex
@@ -269,7 +269,7 @@ func (c VDBManageValidatorsColumn) Int() int {
 
 func (VDBManageValidatorsColumn) NewFromString(s string) VDBManageValidatorsColumn {
 	switch s {
-	case "index":
+	case "", "index":
 		return VDBManageValidatorsIndex
 	case "public_key":
 		return VDBManageValidatorsPublicKey
@@ -409,7 +409,7 @@ func (c VDBRocketPoolColumn) Int() int {
 
 func (VDBRocketPoolColumn) NewFromString(s string) VDBRocketPoolColumn {
 	switch s {
-	case "node":
+	case "", "node":
 		return VDBRocketPoolNode
 	case "collateral":
 		return VDBRocketPoolCollateral
@@ -473,7 +473,7 @@ func (c VDBRocketPoolMinipoolsColumn) Int() int {
 
 func (VDBRocketPoolMinipoolsColumn) NewFromString(s string) VDBRocketPoolMinipoolsColumn {
 	switch s {
-	case "group_id":
+	case "", "group_id":
 		return VDBRocketPoolMinipoolsGroup
 	default:
 		return VDBRocketPoolMinipoolsColumn(-1)

backend/pkg/api/handlers/input_validation.go

@@ -378,7 +378,11 @@ func (v *validationError) parseSortOrder(order string) bool {
 func checkSort[T enums.EnumFactory[T]](v *validationError, sortString string) *types.Sort[T] {
 	var c T
 	if sortString == "" {
-		return &types.Sort[T]{Column: c, Desc: defaultDesc}
+		sortCol := c.NewFromString(sortString)
+		if enums.IsInvalidEnum(sortCol) {
+			sortCol = c
+		}
+		return &types.Sort[T]{Column: sortCol, Desc: defaultDesc}
 	}
 	sortSplit := splitParameters(sortString, ':')
 	if len(sortSplit) > 2 {