fix: link interpolation for translations

Links did not show anymore, as `template tag name` beginning with `_`
did not work anymore.

Author: marcel-bitfly

frontend/components/bc/BcTranslation.vue

@@ -13,13 +13,13 @@ defineProps<{
    *
    * @example
    *
-   * Translation key has to be under `${keypath}._link`
+   * Translation key has to be under `${keypath}.link`
    *
    *  // en.json
    * {
    *  "notifications": {
-   *   "template": "For further information {_link}"
-   *   "_link": "Click here"
+   *   "template": "For further information {link}"
+   *   "link": "Click here"
    * }
    */
   to?: string,
@@ -32,16 +32,16 @@ defineProps<{
     scope="global"
     :tag="tag || 'span'"
   >
-    <template #_bold>
+    <template #bold>
       <span
         v-if="boldpath"
         class="bc-translation-bold"
       >{{ $t(boldpath) }}</span>
     </template>
-    <template #_link>
+    <template #link>
       <slot
         v-if="to && linkpath"
-        name="_link"
+        name="link"
       >
         <BcLink
           class="link"
@@ -52,9 +52,9 @@ defineProps<{
         </BcLink>
       </slot>
     </template>
-    <template #_list>
+    <template #list>
       <slot
-        name="_list"
+        name="list"
         :listpath
       >
         <ul v-if="listpath">

frontend/components/bc/CookieModal.vue

@@ -29,7 +29,7 @@ const visible = computed(() => cookiePreference.value === undefined)
       <BcTranslation
         class="text-container"
         keypath="cookies.text.template"
-        linkpath="cookies.text._link"
+        linkpath="cookies.text.link"
         to="https://storage.googleapis.com/legal.beaconcha.in/privacy.pdf"
       />
       <div class="button-container">

frontend/components/notifications/NotificationsOverview.vue

@@ -73,16 +73,16 @@ const emit = defineEmits<{
         >
           <BcTranslation
             keypath="notifications.overview.notifications_activate_premium.template"
-            linkpath="notifications.overview.notifications_activate_premium._link"
+            linkpath="notifications.overview.notifications_activate_premium.link"
             to="https://discord.com/developers/docs/resources/webhook"
           >
-            <template #_link>
+            <template #link>
               <BcButtonText
                 class="link"
                 :aria-label="$t('notifications.overview.email_activate')"
                 @click="emit('openDialog')"
               >
-                {{ $t('notifications.overview.notifications_activate_premium._link') }}
+                {{ $t('notifications.overview.notifications_activate_premium.link') }}
               </BcButtonText>
             </template>
           </BcTranslation>
@@ -101,7 +101,7 @@ const emit = defineEmits<{
         >
           <BcTranslation
             keypath="notifications.overview.notifications_download_app.template"
-            linkpath="notifications.overview.notifications_download_app._link"
+            linkpath="notifications.overview.notifications_download_app.link"
             to="/mobile"
           />
         </div>

frontend/components/notifications/management/NotificationsManagementPairedDevicesModal.vue

@@ -57,7 +57,7 @@ const handleToggleNotifications = ({
           class="link"
           to="/mobile"
         >
-          {{ $t('notifications.general.paired_devices.info_empty._link') }}
+          {{ $t('notifications.general.paired_devices.info_empty.link') }}
         </BcLink>
       </BcText>
     </div>

frontend/components/notifications/management/NotificationsManagementSubscriptionDialog.vue

@@ -106,7 +106,7 @@ const { hasRocketPool } = useNetworkStore()
           <template #info>
             <BcTranslation
               keypath="notifications.subscriptions.validators.validator_is_offline.info.template"
-              listpath="notifications.subscriptions.validators.validator_is_offline.info._list"
+              listpath="notifications.subscriptions.validators.validator_is_offline.info.list"
             />
           </template>
         </BcSettingsRow>

frontend/components/notifications/management/modal/NotificationsManagementModalWebhook.vue

@@ -144,7 +144,7 @@ const id = useId()
         <template #tooltip>
           <BcTranslation
             keypath="notifications.dashboards.dialog.info_send_via_discord.template"
-            linkpath="notifications.dashboards.dialog.info_send_via_discord._link"
+            linkpath="notifications.dashboards.dialog.info_send_via_discord.link"
             to="https://discord.com/developers/docs/resources/webhook"
           />
         </template>

frontend/components/pricing/PremiumAddonBox.vue

@@ -258,7 +258,7 @@ const handleSubmitPurchase = async () => {
           <BcTranslation
             v-if="isQuantityLimitReached"
             keypath="pricing.addons.contact_support.template"
-            linkpath="pricing.addons.contact_support._link"
+            linkpath="pricing.addons.contact_support.link"
             to="https://dsc.gg/beaconchain"
           />
         </span>

frontend/i18n/locales/en.json

@@ -148,8 +148,8 @@
         "accept_all": "Accept All",
         "only_necessary": "Only Necessary",
         "text": {
-            "_link": "cookies",
-            "template": "By using our site you agree to our use of {_link} to deliver a better user experience."
+            "link": "cookies",
+            "template": "By using our site you agree to our use of {link} to deliver a better user experience."
         }
     },
     "currency": {
@@ -255,8 +255,8 @@
             "text": "Create your own dashboard to get the most out of beaconcha.in"
         },
         "subsciprion_limit_reached": {
-            "_link": "Learn more about our subscription plans and dashboard addon-ons on our pricing page.",
-            "template": "This dashboard exceeds the stake limit so no more validators can be added. {_link}"
+            "link": "Learn more about our subscription plans and dashboard addon-ons on our pricing page.",
+            "template": "This dashboard exceeds the stake limit so no more validators can be added. {link}"
         },
         "subsciprion_limit_reached_title": "Maximum stake exceeded",
         "table": {
@@ -267,8 +267,8 @@
         },
         "title": "Dashboard",
         "truncated_validators": {
-            "_link": "Learn more about how to upgrade and unlock full validator insights and premium features on our pricing page.",
-            "template": "This dashboard displays a truncated list of validators, as their total stake exceeds the free plan limit. {_link}"
+            "link": "Learn more about how to upgrade and unlock full validator insights and premium features on our pricing page.",
+            "template": "This dashboard displays a truncated list of validators, as their total stake exceeds the free plan limit. {link}"
         },
         "validator": {
             "blocks": {
@@ -782,8 +782,8 @@
                 },
                 "heading_webhook": "Edit Webhook",
                 "info_send_via_discord": {
-                    "_link": "Discord webhook",
-                    "template": "Enable this to receive notifications via Discord. Ensure you have a {_link} set up."
+                    "link": "Discord webhook",
+                    "template": "Enable this to receive notifications via Discord. Ensure you have a {link} set up."
                 },
                 "label_send_via_discord": "Send via Discord",
                 "label_webhook_url": "Webhook URL",
@@ -867,7 +867,7 @@
             "paired_devices": {
                 "device": "Device",
                 "info_empty":{
-                    "_link": "Click here to pair a device",
+                    "link": "Click here to pair a device",
                     "template": "Currently there are no devices paired."
                 },
                 "mobile_notifications": "Mobile notifications",
@@ -938,12 +938,12 @@
                 "validator_groups": "Most notified validator groups"
             },
             "notifications_activate_premium": {
-                "_link": "here",
-                "template": "Click {_link} to activate"
+                "link": "here",
+                "template": "Click {link} to activate"
             },
             "notifications_download_app": {
-                "_link": "mobile app",
-                "template": "Download the {_link} to activate"
+                "link": "mobile app",
+                "template": "Download the {link} to activate"
             },
             "push": "Push"
         },
@@ -1017,8 +1017,8 @@
                 },
                 "validator_is_offline": {
                     "info": {
-                        "_list": "Once the validator has been offline for 3 epochs\nOnce you are back online again",
-                        "template": "We will trigger a notification: {_list}"
+                        "list": "Once the validator has been offline for 3 epochs\nOnce you are back online again",
+                        "template": "We will trigger a notification: {list}"
                     },
                     "label": "Validator is offline"
                 },
@@ -1051,8 +1051,8 @@
                 "select_addon": "Select Add-On"
             },
             "contact_support":{
-                "_link": "support",
-                "template": "Contact our {_link} for a higher limit"
+                "link": "support",
+                "template": "Contact our {link} for a higher limit"
             },
             "currently_active": "Currently active: {amount}",
             "effective_balance": "+{amount} Max Stake per Dashboard",

frontend/pages/dashboard/[[id]]/index.vue

@@ -428,7 +428,7 @@ const isTruncated = computed(() => 'isTruncated' in route.query)
         >
           <BcTranslation
             keypath="dashboard.subsciprion_limit_reached.template"
-            linkpath="dashboard.subsciprion_limit_reached._link"
+            linkpath="dashboard.subsciprion_limit_reached.link"
             to="/premium"
           />
         </BcNotificationBanner>
@@ -438,7 +438,7 @@ const isTruncated = computed(() => 'isTruncated' in route.query)
         >
           <LazyBcTranslation
             keypath="dashboard.truncated_validators.template"
-            linkpath="dashboard.truncated_validators._link"
+            linkpath="dashboard.truncated_validators.link"
             to="/premium"
           />
         </BcNotificationBanner>