refactor: unified percent scaling

Author: remoterami

backend/pkg/api/data_access/vdb_helpers.go

@@ -212,8 +212,7 @@ func calcAPR(rewards, cumulativeDivisor decimal.Decimal, duration time.Duration)
 		return 0
 	}
 	annualizationFactor := decimal.NewFromInt(utils.Year.Nanoseconds()).Div(decimal.NewFromInt(duration.Nanoseconds()))
-	percentScaleFactor := decimal.NewFromInt(100) // TODO remove BEDS-1147
-	return rewards.Div(cumulativeDivisor).Mul(annualizationFactor).Mul(percentScaleFactor).InexactFloat64()
+	return rewards.Div(cumulativeDivisor).Mul(annualizationFactor).InexactFloat64()
 }
 
 // converts a cl amount to the main currency

backend/pkg/api/data_access/vdb_management.go

@@ -412,7 +412,6 @@ func (d *DataAccessService) GetValidatorDashboardOverview(ctx context.Context, d
 			}
 
 			*efficiency, err = runQuery[float64](ctx, d.clickhouseReader, ds)
-			*efficiency *= 100
 			return err
 		})
 	}

backend/pkg/api/data_access/vdb_rewards.go

@@ -367,15 +367,15 @@ func (d *DataAccessService) GetValidatorDashboardRewards(ctx context.Context, da
 	for _, res := range queryResult {
 		duty := t.VDBRewardsTableDuty{}
 		if res.AttestationsScheduled > 0 {
-			attestationPercentage := (float64(res.AttestationsExecuted) / float64(res.AttestationsScheduled)) * 100.0
+			attestationPercentage := (float64(res.AttestationsExecuted) / float64(res.AttestationsScheduled))
 			duty.Attestation = &attestationPercentage
 		}
 		if res.BlocksScheduled > 0 {
-			ProposalPercentage := (float64(res.BlocksProposed) / float64(res.BlocksScheduled)) * 100.0
+			ProposalPercentage := (float64(res.BlocksProposed) / float64(res.BlocksScheduled))
 			duty.Proposal = &ProposalPercentage
 		}
 		if res.SyncScheduled > 0 {
-			SyncPercentage := (float64(res.SyncExecuted) / float64(res.SyncScheduled)) * 100.0
+			SyncPercentage := (float64(res.SyncExecuted) / float64(res.SyncScheduled))
 			duty.Sync = &SyncPercentage
 		}
 
@@ -425,15 +425,15 @@ func (d *DataAccessService) GetValidatorDashboardRewards(ctx context.Context, da
 
 		duty := t.VDBRewardsTableDuty{}
 		if totalInfo.AttestationsScheduled > 0 {
-			attestationPercentage := (float64(totalInfo.AttestationsExecuted) / float64(totalInfo.AttestationsScheduled)) * 100.0
+			attestationPercentage := (float64(totalInfo.AttestationsExecuted) / float64(totalInfo.AttestationsScheduled))
 			duty.Attestation = &attestationPercentage
 		}
 		if totalInfo.BlocksScheduled > 0 {
-			proposalPercentage := (float64(totalInfo.BlocksProposed) / float64(totalInfo.BlocksScheduled)) * 100.0
+			proposalPercentage := (float64(totalInfo.BlocksProposed) / float64(totalInfo.BlocksScheduled))
 			duty.Proposal = &proposalPercentage
 		}
 		if totalInfo.SyncScheduled > 0 {
-			SyncPercentage := (float64(totalInfo.SyncExecuted) / float64(totalInfo.SyncScheduled)) * 100.0
+			SyncPercentage := (float64(totalInfo.SyncExecuted) / float64(totalInfo.SyncScheduled))
 			duty.Sync = &SyncPercentage
 		}
 

backend/pkg/api/data_access/vdb_summary.go

@@ -93,7 +93,7 @@ func (d *DataAccessService) GetValidatorDashboardSummary(ctx context.Context, da
 	}
 	var averageNetworkEfficiency float64
 	if efficiency.TotalEfficiency[period].Valid {
-		averageNetworkEfficiency = efficiency.TotalEfficiency[period].Float64 * 100
+		averageNetworkEfficiency = efficiency.TotalEfficiency[period].Float64
 	}
 
 	// ------------------------------------------------------------------------------------------------------------------
@@ -738,7 +738,7 @@ func (d *DataAccessService) GetValidatorDashboardGroupSummary(ctx context.Contex
 	}
 
 	if totalBlockChance > 0 {
-		ret.Luck.Proposal.Percent = (float64(totalBlocksScheduled)) / totalBlockChance * 100
+		ret.Luck.Proposal.Percent = (float64(totalBlocksScheduled)) / totalBlockChance
 
 		// calculate the average time it takes for the set of validators to propose a single block on average
 		ret.Luck.Proposal.AverageIntervalSeconds = uint64(time.Duration((luckHours / totalBlockChance) * float64(time.Hour)).Seconds())
@@ -754,7 +754,7 @@ func (d *DataAccessService) GetValidatorDashboardGroupSummary(ctx context.Contex
 		totalSyncSlotDuties := float64(ret.SyncCommittee.StatusCount.Failed) + float64(ret.SyncCommittee.StatusCount.Success)
 		slotDutiesPerSyncCommittee := float64(utils.SlotsPerSyncCommittee())
 		syncCommittees := math.Ceil(totalSyncSlotDuties / slotDutiesPerSyncCommittee) // gets the number of sync committees
-		ret.Luck.Sync.Percent = syncCommittees / totalSyncExpected * 100
+		ret.Luck.Sync.Percent = syncCommittees / totalSyncExpected
 
 		// calculate the average time it takes for the set of validators to be elected into a sync committee on average
 		ret.Luck.Sync.AverageIntervalSeconds = uint64(time.Duration((luckHours / totalSyncExpected) * float64(time.Hour)).Seconds())
@@ -817,7 +817,7 @@ func calcEfficiency(dividend, divisor decimal.Decimal) float64 {
 	if divisor.IsZero() {
 		return 0
 	}
-	return dividend.Div(divisor).InexactFloat64() * 100
+	return dividend.Div(divisor).InexactFloat64()
 }
 
 // for summary charts: series id is group id, no stack
@@ -945,9 +945,9 @@ func (d *DataAccessService) GetValidatorDashboardSummaryChart(ctx context.Contex
 			if data[row.Timestamp][row.GroupId] == 0 {
 				continue
 			}
-			if data[row.Timestamp][row.GroupId] > 100 {
+			if data[row.Timestamp][row.GroupId] > 1 {
 				log.Error(nil, "efficiency is greater than 100%", 0, map[string]interface{}{"efficiency": efficiency})
-				data[row.Timestamp][row.GroupId] = 100
+				data[row.Timestamp][row.GroupId] = 1
 			}
 			groupMap[row.GroupId] = true
 		}
@@ -971,7 +971,7 @@ func (d *DataAccessService) GetValidatorDashboardSummaryChart(ctx context.Contex
 		}
 		var averageNetworkEfficiency float64
 		if efficiency.AttestationEfficiency[enums.Last24h].Valid {
-			averageNetworkEfficiency = efficiency.AttestationEfficiency[enums.Last24h].Float64 * 100
+			averageNetworkEfficiency = efficiency.AttestationEfficiency[enums.Last24h].Float64
 		}
 
 		for ts := range tsMap {
@@ -990,9 +990,9 @@ func (d *DataAccessService) GetValidatorDashboardSummaryChart(ctx context.Contex
 			if data[row.Timestamp][totalLineGroupId] == 0 {
 				continue
 			}
-			if data[row.Timestamp][totalLineGroupId] > 100 {
+			if data[row.Timestamp][totalLineGroupId] > 1 {
 				log.Error(nil, "efficiency is greater than 100%", 0, map[string]interface{}{"efficiency": efficiency})
-				data[row.Timestamp][totalLineGroupId] = 100
+				data[row.Timestamp][totalLineGroupId] = 1
 			}
 		}
 		groupMap[totalLineGroupId] = true