fix(monitoring) rp & pubkey healthz only on prod

invis-bitfly · guybrush · commit f1458a50aecb · 2025-01-22T16:26:46.000+01:00
diff --git a/backend/pkg/monitoring/services/base.go b/backend/pkg/monitoring/services/base.go
@@ -113,9 +113,10 @@ func NewStatusReport(id constants.Event, timeout time.Duration, check_interval t
 func GetRequiredEvents() []constants.Event {
 	// i would hope this simple of a function doesnt need caching
 	requiredEvents := constants.RequiredEvents
-	if utils.Config.DeploymentType == "production" {
-		requiredEvents = append(requiredEvents, constants.ProductionRequiredEvents...)
+	if utils.Config.DeploymentType != "production" {
+		return requiredEvents
 	}
+	requiredEvents = append(requiredEvents, constants.ProductionRequiredEvents...)
 	if utils.Config.RocketpoolExporter.Enabled {
 		requiredEvents = append(requiredEvents, constants.Event_ExporterLegacyRocketPool)
 	}

Original file line number	Diff line number	Diff line change
`@@ -113,9 +113,10 @@ func NewStatusReport(id constants.Event, timeout time.Duration, check_interval t`
`113`	`113`	`func GetRequiredEvents() []constants.Event {`
`114`	`114`	`// i would hope this simple of a function doesnt need caching`
`115`	`115`	`requiredEvents := constants.RequiredEvents`
`116`		`- if utils.Config.DeploymentType == "production" {`
`117`		`- requiredEvents = append(requiredEvents, constants.ProductionRequiredEvents...)`
	`116`	`+ if utils.Config.DeploymentType != "production" {`
	`117`	`+ return requiredEvents`
`118`	`118`	`}`
	`119`	`+ requiredEvents = append(requiredEvents, constants.ProductionRequiredEvents...)`
`119`	`120`	`if utils.Config.RocketpoolExporter.Enabled {`
`120`	`121`	`requiredEvents = append(requiredEvents, constants.Event_ExporterLegacyRocketPool)`
`121`	`122`	`}`