Replace inefficient set exists with mem

Author: sim642

src/analyses/extractPthread.ml

@@ -168,7 +168,7 @@ module Tbls = struct
     let get_fun_for_tid v =
       table
       |> Hashtbl.to_seq
-      |> Seq.find_map (fun (k,v') -> if Set.exists (( = ) v) v' then Some k else None)
+      |> Seq.find_map (fun (k,v') -> if Set.mem v v' then Some k else None)
   end
 
   module MutexMidTbl = SymTbl (struct

src/cdomain/value/cdomains/int/enumsDomain.ml

@@ -340,7 +340,7 @@ module Enums : S with type int_t = Z.t = struct
     | Exc (e,_) when BISet.is_empty e -> None
     | Inc zero when BISet.is_singleton zero && BISet.choose zero = Z.zero -> Some false
     | Inc xs when not (BISet.mem Z.zero xs) -> Some true
-    | Exc (xs,_) when BISet.exists ((=) Z.zero) xs -> Some true
+    | Exc (xs,_) when BISet.mem Z.zero xs -> Some true
     | _ -> None
   let to_int = function Inc x when BISet.is_singleton x -> Some (BISet.choose x) | _ -> None
 

src/cdomains/regionDomain.ml

@@ -36,7 +36,6 @@ struct
   let kill x (y:t): t = lift (VF.kill x) y
   let replace x exp y = lift (VF.replace x exp) y
 
-  let is_bullet x = x = `Right ()
   let bullet = `Right ()
   let of_vf vf = `Left vf
   let real_region (x:t): bool = match x with
@@ -50,7 +49,7 @@ module RS = struct
   let single_vf vf = singleton (VFB.of_vf vf)
   let single_bullet = singleton (VFB.bullet)
   let remove_bullet x = remove VFB.bullet x
-  let has_bullet x = exists VFB.is_bullet x
+  let has_bullet x = mem VFB.bullet x
   let is_single_bullet rs =
     not (is_top rs) &&
     cardinal rs = 1 &&