Merge pull request #1724 from goblint/tests-fun-ptr-void

Explicitly specify no-argument function pointers in tests

Author: sim642

tests/incremental/11-restart/11-paper-example.c

@@ -3,7 +3,7 @@
 
 pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER;
 
-int (*fp)() = NULL;
+int (*fp)(void) = NULL;
 
 int bad() {
     return -1;

tests/regression/00-sanity/15-unused_arg.c

@@ -4,9 +4,9 @@ void f() {
   glob++; // NOWARN!
 }
 
-void (*fptr) = f;
+void (*fptr)(void) = f;
 
-int g(void (*ptr)()) {
+int g(void (*ptr)(void)) {
   return 0;
 }
 

tests/regression/00-sanity/38-evalfunvar-dead.c

@@ -1,7 +1,7 @@
 #include <stdlib.h>
 
 int main() {
-  int (*fp)() = &rand;
+  int (*fp)(void) = &rand;
   abort();
   fp(); // NOWARN (No suitable function to call)
   return 0;

tests/regression/01-cpa/06-pointers.c

@@ -8,7 +8,7 @@ int fun_5b() { return 5; }
 int main () {
   int i,j,k1,k2,k3;
   int *p, **pp;
-  int (*fp)(); //pointer to function
+  int (*fp)(void); //pointer to function
 
   // reading through pointer
   i = 5;

tests/regression/01-cpa/09-arrays.c

@@ -18,9 +18,9 @@ int main () {
 
   int a[] = {2,2,2};
   int b[2], c[3];
-  int (*f[2])() = {fun_5, fun_6};
-  int (*g[2])() = {fun_5, fun_5b};
-  int (*fp)();
+  int (*f[2])(void) = {fun_5, fun_6};
+  int (*g[2])(void) = {fun_5, fun_5b};
+  int (*fp)(void);
   int *ip;
   int (*iap)[];
 

tests/regression/01-cpa/46-funptr_path.c

@@ -16,7 +16,7 @@ void fun2() {
 int main() {
   int x = __VERIFIER_nondet_int();
 
-  void (*fp)();
+  void (*fp)(void);
 
   if (x) {
     pthread_mutex_lock(&mutex);

tests/regression/02-base/46-spawn-global-funptrs.c

@@ -9,13 +9,13 @@ void bar() {
   __goblint_check(1); // assert reachable
 }
 
-void (*funs[2])() = {
+void (*funs[2])(void) = {
   &foo,
   &bar
 };
 
 extern void magic1();
-extern void magic2(void (*funs[])());
+extern void magic2(void (*funs[])(void));
 
 int main() {
   magic1(); // invalidate funs a bit

tests/regression/03-practical/06-callback.c

@@ -9,7 +9,7 @@ void callme(void)  {
   x = 5;
 }
 
-void callfun(void (*fun)()) {
+void callfun(void (*fun)(void)) {
   fun();
   return;
 }

tests/regression/04-mutex/19-call_by_ptr_rc.c

@@ -2,7 +2,7 @@ extern int __VERIFIER_nondet_int();
 
 #include<pthread.h>
 
-void foo(int (*callback)()) {
+void foo(int (*callback)(void)) {
   for (int i = 0; i < 10; i++) {
     if (__VERIFIER_nondet_int())
       callback();

tests/regression/04-mutex/21-sound_base.c

@@ -6,7 +6,7 @@ int global;
 void bad() { global++; } // RACE!
 void good() { printf("Hello!"); }
 
-void (*f)() = good;
+void (*f)(void) = good;
 
 void *t_fun(void *arg) {
   f(); // RACE!