Skip to content

Commit 50c7cb7

Browse files
Fix code review issues in MCP server
- Set analyzed flag in analyze() function instead of tool handlers - Remove duplicate code in architecture documentation Co-authored-by: michael-schwarz <13812333+michael-schwarz@users.noreply.github.com>
1 parent 1356469 commit 50c7cb7

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

docs/developer-guide/mcp-architecture.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,6 @@ Each tool follows this pattern:
7676
(* 4. Return result *)
7777
ToolResult.make_text "Success message"
7878
```
79-
80-
(* 4. Return result *)
81-
ToolResult.make_text "Success message"
82-
```
8379

8480
## Configuration Handling
8581

src/util/mcpServer.ml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,9 @@ let analyze ?(reset=false) (mcp_serv: t) =
187187
(* Run analysis *)
188188
Maingoblint.do_analyze None file;
189189
Maingoblint.do_gobview file;
190+
191+
(* Mark as analyzed *)
192+
mcp_serv.analyzed <- true
190193

191194
(** JSON Schema helpers *)
192195
let string_schema = `Assoc [("type", `String "string")]
@@ -405,7 +408,6 @@ let handle_tools_call (mcp_serv: t) (call: ToolCall.t) =
405408

406409
(* Run analysis directly *)
407410
analyze mcp_serv ~reset;
408-
mcp_serv.analyzed <- true;
409411

410412
let status = if !AnalysisState.verified = Some false then "VerifyError" else "Success" in
411413
let msg_count = List.length (Messages.Table.to_list ()) in
@@ -423,7 +425,6 @@ let handle_tools_call (mcp_serv: t) (call: ToolCall.t) =
423425

424426
(* Run analysis directly *)
425427
analyze mcp_serv ~reset;
426-
mcp_serv.analyzed <- true;
427428

428429
let status = if !AnalysisState.verified = Some false then "VerifyError" else "Success" in
429430
let msg_count = List.length (Messages.Table.to_list ()) in

0 commit comments

Comments
 (0)