partially rename functions and variables: unique -> must_ancestor

Author: dabund24

src/analyses/creationLockset.ml

@@ -38,10 +38,10 @@ module Spec = struct
       @param ask any ask
       @param tid
   *)
-  let unique_descendants_closure (ask : Queries.ask) tid =
+  let must_ancestor_descendants_closure (ask : Queries.ask) tid =
     let descendants = ask.f @@ Queries.DescendantThreads tid in
-    let unique_descendants = TIDs.filter (TID.must_be_ancestor tid) descendants in
-    TIDs.add tid unique_descendants
+    let must_ancestors_descendants = TIDs.filter (TID.must_be_ancestor tid) descendants in
+    TIDs.add tid must_ancestors_descendants
 
   let threadspawn man ~multiple lval f args fman =
     let ask = ask_of_man man in
@@ -50,26 +50,26 @@ module Spec = struct
     let child_tid_lifted = child_ask.f Queries.CurrentThreadId in
     match tid_lifted, child_tid_lifted with
     | `Lifted tid, `Lifted child_tid when TID.must_be_ancestor tid child_tid ->
-      let unique_descendants = unique_descendants_closure child_ask child_tid in
+      let must_ancestor_descendants = must_ancestor_descendants_closure child_ask child_tid in
       let lockset = ask.f Queries.MustLockset in
       let to_contribute = G.singleton tid lockset in
-      TIDs.iter (contribute_locks man to_contribute) unique_descendants
+      TIDs.iter (contribute_locks man to_contribute) must_ancestor_descendants
     | _ -> ()
 
   (** compute all descendant threads that may run along with the ego thread at a program point.
       for all of them, tid must be an ancestor
       @param tid ego thread id
       @param ask ask of ego thread at the program point
   *)
-  let get_unique_running_descendants tid (ask : Queries.ask) =
+  let get_must_ancestor_running_descendants tid (ask : Queries.ask) =
     let may_created_tids = ask.f Queries.CreatedThreads in
-    let may_unique_created_tids =
+    let may_must_ancestor_created_tids =
       TIDs.filter (TID.must_be_ancestor tid) may_created_tids
     in
     let may_transitively_created_tids =
       TIDs.fold
-        (fun child_tid acc -> TIDs.union acc (unique_descendants_closure ask child_tid))
-        may_unique_created_tids
+        (fun child_tid acc -> TIDs.union acc (must_ancestor_descendants_closure ask child_tid))
+        may_must_ancestor_created_tids
         (TIDs.empty ())
     in
     let must_joined_tids = ask.f Queries.MustJoinedThreads in
@@ -101,7 +101,7 @@ module Spec = struct
       let tid_lifted = ask.f Queries.CurrentThreadId in
       (match tid_lifted with
        | `Lifted tid ->
-         let possibly_running_tids = get_unique_running_descendants tid ask in
+         let possibly_running_tids = get_must_ancestor_running_descendants tid ask in
          let lock_opt = LockDomain.MustLock.of_addr addr in
          (match lock_opt with
           | Some lock -> unlock man tid possibly_running_tids lock