Revert "Merge remote-tracking branch 'upstream/master' into relationalArray"

This reverts commit 9a033b4.

Author: FungOliver

.github/workflows/coverage.yml

@@ -65,9 +65,6 @@ jobs:
       - name: Test apron regression (Mukherjee et. al  SAS '17 paper') # skipped by default but CI has apron, so explicitly test group (which ignores skipping -- it's now a feature!)
         run: ruby scripts/update_suite.rb group apron-mukherjee -s
 
-      - name: Test apron termination regression # skipped by default but CI has apron, so explicitly test group (which ignores skipping -- it's now a feature!)
-        run: ruby scripts/update_suite.rb group termination -s
-
       - name: Test regression cram
         run: opam exec -- dune runtest tests/regression
 
@@ -88,7 +85,7 @@ jobs:
           COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
           PULL_REQUEST_NUMBER: ${{ github.event.number }}
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
           name: suite_result

.github/workflows/docs.yml

@@ -46,7 +46,7 @@ jobs:
 
       - name: Setup Pages
         id: pages
-        uses: actions/configure-pages@v4
+        uses: actions/configure-pages@v3
 
       - name: Install dependencies
         run: opam install . --deps-only --locked --with-doc
@@ -68,4 +68,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v3
+        uses: actions/deploy-pages@v2

.github/workflows/locked.yml

@@ -64,9 +64,6 @@ jobs:
       - name: Test apron regression (Mukherjee et. al  SAS '17 paper') # skipped by default but CI has apron, so explicitly test group (which ignores skipping -- it's now a feature!)
         run: ruby scripts/update_suite.rb group apron-mukherjee -s
 
-      - name: Test apron termination regression # skipped by default but CI has apron, so explicitly test group (which ignores skipping -- it's now a feature!)
-        run: ruby scripts/update_suite.rb group termination -s
-
       - name: Test regression cram
         run: opam exec -- dune runtest tests/regression
 
@@ -82,10 +79,10 @@ jobs:
       - name: Test incremental regression with cfg comparison
         run: ruby scripts/update_suite.rb -c
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v3
         if: always()
         with:
-          name: suite_result-${{ matrix.os }}
+          name: suite_result
           path: tests/suite_result/
 
   extraction:
@@ -156,7 +153,7 @@ jobs:
           ocaml-compiler: ${{ matrix.ocaml-compiler }}
 
       - name: Set up Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
 

.github/workflows/metadata.yml

@@ -27,9 +27,6 @@ jobs:
           args: --validate
 
   zenodo-validate:
-    # Zenodo schema URL is dead
-    if: ${{ false }}
-
     strategy:
       matrix:
         node-version:
@@ -42,7 +39,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
 

.github/workflows/options.yml

@@ -18,18 +18,18 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v4
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
 
       - name: Install ajv-cli
         run: npm install -g ajv-cli
 
       - name: Migrate schema # https://github.com/ajv-validator/ajv-cli/issues/199
-        run: ajv migrate -s src/config/options.schema.json
+        run: ajv migrate -s src/common/util/options.schema.json
 
       - name: Validate conf
-        run: ajv validate -s src/config/options.schema.json -d "conf/**/*.json"
+        run: ajv validate -s src/common/util/options.schema.json -d "conf/**/*.json"
 
       - name: Validate incremental tests
-        run: ajv validate -s src/config/options.schema.json -d "tests/incremental/*/*.json"
+        run: ajv validate -s src/common/util/options.schema.json -d "tests/incremental/*/*.json"

.github/workflows/semgrep.yml

@@ -22,7 +22,7 @@ jobs:
         run: semgrep scan --config .semgrep/ --sarif > semgrep.sarif
 
       - name: Upload SARIF file to GitHub Advanced Security Dashboard
-        uses: github/codeql-action/upload-sarif@v3
+        uses: github/codeql-action/upload-sarif@v2
         with:
           sarif_file: semgrep.sarif
         if: always()

.github/workflows/unlocked.yml

@@ -92,10 +92,6 @@ jobs:
         if: ${{ matrix.apron }}
         run: ruby scripts/update_suite.rb group apron-mukherjee -s
 
-      - name: Test apron termination regression # skipped by default but CI has apron, so explicitly test group (which ignores skipping -- it's now a feature!)
-        if: ${{ matrix.apron }}
-        run: ruby scripts/update_suite.rb group termination -s
-
       - name: Test regression cram
         run: opam exec -- dune runtest tests/regression
 
@@ -160,8 +156,7 @@ jobs:
 
       - name: Downgrade dependencies
         # must specify ocaml-base-compiler again to prevent it from being downgraded
-        # prevent num downgrade to avoid dune/jbuilder error: https://github.com/ocaml/dune/issues/5280
-        run: opam install $(opam exec -- opam-0install --prefer-oldest goblint ocaml-variants.4.14.0+options ocaml-option-flambda num.1.4)
+        run: opam install $(opam exec -- opam-0install --prefer-oldest goblint ocaml-variants.4.14.0+options ocaml-option-flambda)
 
       - name: Build
         run: ./make.sh nat

.gitignore

@@ -29,6 +29,7 @@ linux-headers
 .goblint*/
 goblint_temp_*/
 
+src/spec/graph
 .vagrant
 
 g2html.jar

.gitmodules

@@ -4,3 +4,6 @@
 [submodule "g2html"]
 	path = g2html
 	url = https://github.com/goblint/g2html.git
+[submodule "gobview"]
+	path = gobview
+	url = https://github.com/goblint/gobview.git

.mailmap

@@ -23,7 +23,6 @@ Kerem Çakırer <kcakirer@hotmail.com> <cakirerkerem@gmail.com>
 Sarah Tilscher <66023521+stilscher@users.noreply.github.com>
 Karoliine Holter <karoliine.holter@ut.ee>
 <karoliine.holter@ut.ee> <44437975+karoliineh@users.noreply.github.com>
-<karoliine.holter@ut.ee> <karoliine.holter@hotmail.com>
 
 Elias Brandstetter <brandste@in.tum.de> <15275491+superbr4in@users.noreply.github.com>
 wherekonshade <wherekonshade@web.de> <80516286+Wherekonshade@users.noreply.github.com>
@@ -38,6 +37,3 @@ Mireia Cano Pujol <mcanopujol@gmail.com>
 Felix Krayer <felix@krayernet.eu>
 Felix Krayer <felix@krayernet.eu> <91671586+FelixKrayer@users.noreply.github.com>
 Manuel Pietsch <manuelpietsch@outlook.de>
-Tim Ortel <100865202+TimOrtel@users.noreply.github.com>
-Tomáš Dacík <xdacik00@stud.fit.vutbr.cz>
-<xdacik00@stud.fit.vutbr.cz> <43824605+TDacik@users.noreply.github.com>