Merge pull request #1955 from goblint/issue_1934-str-not-an-address

Treat string function non-address inputs as top values

Author: sim642

src/analyses/base.ml

@@ -2434,7 +2434,7 @@ struct
           | Addr.Addr (v, o) -> Addr.Addr (v, lo o)
           | other -> other in
         AD.map rmLastOffset a
-      | _ -> raise (Failure "String function: not an address")
+      | _ -> AD.top ()
     in
     let string_manipulation s1 s2 lv all op_addr op_array =
       let s1_v = eval_rv ~man st s1 in

tests/regression/73-strings/11-not-an-address.c

@@ -0,0 +1,18 @@
+// NOCRASH
+extern int strcmp(const char *, const char *);
+
+static int hello_read(const char *path) {
+    return strcmp(path, "Hello");
+}
+
+static const struct ops {
+	int (*read)(const char *);
+} hello_oper = {
+	.read = hello_read,
+};
+
+extern int main_real(const struct ops *);
+
+int main() {
+	return main_real(&hello_oper);
+}