Fix mine-W-noinit not resetting W in threadenter#1640
Merged
Conversation
sim642
changed the title
mine-W-noinit not resetting W in threadentermine-W-noinit not resetting W in threadenter
michael-schwarz
approved these changes
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This privatization is supposed to keep in the set$$W$$ globals may-written by the current thread. Currently
threadenterpropagates this set to the created thread which may thus create spurious side effects on behalf of the created thread who doesn't ever write the global.This PR fixes that by resetting$$W$$ in
threadenter.(This is orthogonal to #1613 which also suffers from the same issue on the same test.)