Upgrade GobView to OCaml 5#1749
Merged
Merged
Conversation
michael-schwarz
approved these changes
May 22, 2025
Member
Author
|
I'm not sure what's going on, but it's still broken in the nightly CI (https://github.com/goblint/analyzer/actions/runs/15290394782/job/43008642771): It's especially weird because it succeeded in the manual CI job I ran on the branch beforehand. |
Member
|
Is it a dependency issue somehow? Or one of the newer PRs? Maybe worth bisecting? |
Member
Author
|
I didn't do a careful analysis, but one thing that changed was #1753, changing ocamlfind from 1.9.6 to 1.9.8. This is part of ocamlfind 1.9.7, but I don't know if this is the cause: ocaml/ocamlfind#76. |
sim642
added a commit
that referenced
this pull request
Jul 2, 2025
Failure since #1749 (comment). Hopefully this works.
Member
Author
|
I finally looked into it and looks like it was just batteries being used instead of batteries.unthreaded: 63df974. The GobView job finally succeeded after two months of daily failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix GobView being uninstallable after #1708.
TODO