Remove Unknown castkind

Author: sim642

src/cil.ml

@@ -624,7 +624,6 @@ and castkind =
   | PointerConversion (** Pointer conversion (non-standard). @see C11 6.5.6.8, 6.5.8.5 and 6.5.9.5. *)
   | Implicit (** Implicit conversion. @see C11 6.3.1, 6.5.2.2.7, 6.5.2.4.2, 6.5.16.1.2, 6.5.16.2.3, 6.7.9.11, 6.8.4.2.5 and 6.8.6.4.3. *)
   | Internal (** CIL-internal conversion (non-standard). *)
-  | Unknown (** Unknown conversion. *)
 
 (** An lvalue denotes the contents of a range of memory addresses. This range
    is denoted as a host object along with an offset within the object. The
@@ -2893,7 +2892,6 @@ let d_castkind () k =
   | PointerConversion -> text "PointerConversion"
   | Implicit -> text "Implicit"
   | Internal -> text "Internal"
-  | Unknown -> text "Unknown"
 
 let invalidStmt = mkStmt (Instr [])
 

src/cil.mli

@@ -733,7 +733,6 @@ and castkind =
   | PointerConversion (** Pointer conversion (non-standard). @see C11 6.5.6.8, 6.5.8.5 and 6.5.9.5. *)
   | Implicit (** Implicit conversion. @see C11 6.3.1, 6.5.2.2.7, 6.5.2.4.2, 6.5.16.1.2, 6.5.16.2.3, 6.7.9.11, 6.8.4.2.5 and 6.8.6.4.3. *)
   | Internal (** CIL-internal conversion (non-standard). *)
-  | Unknown (** Unknown conversion. *)
 
 (** {b Lvalues.} Lvalues are the sublanguage of expressions that can appear at the left of an assignment or as operand to the address-of operator.
 In C the syntax for lvalues is not always a good indication of the meaning

src/ext/zrapp/rmciltmps.ml

@@ -429,7 +429,7 @@ let varXformClass action data sid fd nofrm = object(self)
 	None -> DoChildren
       | Some e' ->
           (* Cast e' to the correct type. *)
-          let e'' = mkCast ~kind:Unknown ~e:e' ~newt:vi.vtype in
+          let e'' = mkCast ~kind:Internal ~e:e' ~newt:vi.vtype in
           ChangeTo e'')
   | Lval(Mem e', off) ->
       (* don't substitute constants in memory lvals *)
@@ -468,15 +468,15 @@ let lvalXformClass action data sid fd nofrm = object(self)
 	    in
 	    ChangeDoChildrenPost(Lval(Mem e', off), post)
 	| Some e' ->
-	    let e'' = mkCast ~kind:Unknown ~e:e' ~newt:(typeOf(Lval lv)) in
+	    let e'' = mkCast ~kind:Internal ~e:e' ~newt:(typeOf(Lval lv)) in
 	    ChangeDoChildrenPost(e'', castrm)
     end
     | Lval lv -> begin
 	match action data sid lv fd nofrm with
 	| None -> DoChildren
 	| Some e' -> begin
             (* Cast e' to the correct type. *)
-            let e'' = mkCast ~kind:Unknown ~e:e' ~newt:(typeOf(Lval lv)) in
+            let e'' = mkCast ~kind:Internal ~e:e' ~newt:(typeOf(Lval lv)) in
             ChangeDoChildrenPost(e'', castrm)
 	end
     end

src/formatcil.ml

@@ -157,7 +157,7 @@ let test () =
   (* Construct an instruction *)
   let makeInstr () =
     Call(Some (var res),
-         Lval (Mem (CastE(Unknown, TPtr(TFun(TPtr(intType, []),
+         Lval (Mem (CastE(Explicit, TPtr(TFun(TPtr(intType, []),
                                     Some [ ("", intType, []);
                                            ("a2", TPtr(intType, []), []);
                                            ("a3", TPtr(TPtr(intType, []),

src/formatparse.mly

@@ -1354,7 +1354,7 @@ stmt:
                         let e = (fst $3) args in
                         let e =
                           if isPointerType(typeOf e) then
-                            mkCast ~kind:Unknown ~e:e ~newt:!upointType
+                            mkCast ~kind:Internal ~e:e ~newt:!upointType (* TODO: why this cast here? not done for other ifs/loops *)
                           else e
                         in
                         mkStmt

src/frontc/cabs2cil.ml

@@ -1473,8 +1473,7 @@ let rec castTo ~kind
     | ConditionalConversion
     | PointerConversion
     | Implicit
-    | Internal
-    | Unknown -> false
+    | Internal -> false
   in
   let debugCast = false in
   if debugCast then
@@ -4329,7 +4328,7 @@ and doExp (asconst: bool)   (* This expression is used as a constant *)
         | CEExp (se, e) ->
           let e' =
             let te = typeOf e in
-            let _, zte = castTo ~kind:Unknown intType te zero in
+            let _, zte = castTo ~kind:Internal intType te zero in (* TODO: is this even reachable? *)
             BinOp(Ne, e, zte, intType)
           in
           finishExp se e' intType