refactor: reduce dependencies and update to Go 1.25

Remove 4 direct dependencies by replacing with internal implementations:
- Remove github.com/dustin/go-humanize with internal formatBytes()
- Remove github.com/gobuffalo/grift (was dead code)
- Remove github.com/psanford/memfs with testing/fstest.MapFS
- Remove github.com/gobuffalo/nulls with internal/nulls package
- Remove direct dependency on github.com/gobuffalo/envy (transitive via meta remains)

Promote github.com/joho/godotenv to direct dependency for .env support.
Update go directive from 1.23.0 to 1.25.0.
Fix Go 1.25 non-constant format string errors.

Author: paganotoni

README.md

@@ -53,10 +53,6 @@ Buffalo would not be possible if not for all of the great projects it depends on
 
 [github.com/gorilla/mux](https://github.com/gorilla/mux) - This router was chosen because of its stability and flexibility. There might be faster routers out there, but this one is definitely the most powerful!
 
-### Task Runner (Optional)
-
-[github.com/markbates/grift](https://github.com/markbates/grift) - If you're familiar with Rake tasks from Ruby, you'll be right at home using Grift. This package was chosen to allow for the easy running of simple, and common, tasks that most web applications need. Think things like seeding a database or taking in a CSV file and generating database records. Buffalo ships with an example `routes` task that prints of the defined routes and the function that handles those requests.
-
 ### Models/ORM (Optional)
 
 [github.com/gobuffalo/pop](https://github.com/gobuffalo/pop) - Accessing databases is nothing new in web applications. Pop, and its command line tool, Soda, were chosen because they strike a nice balance between simplifying common tasks, being idiomatic, and giving you the flexibility you need to build your app. Pop and Soda share the same core philosophies as Buffalo, so they were a natural choice.

SHOULDERS.md

@@ -14,11 +14,10 @@ Thank you to the following **GIANTS**:
 * [github.com/felixge/httpsnoop](https://godoc.org/github.com/felixge/httpsnoop)
 * [github.com/fsnotify/fsnotify](https://godoc.org/github.com/fsnotify/fsnotify)
 * [github.com/go-sql-driver/mysql](https://godoc.org/github.com/go-sql-driver/mysql)
-* [github.com/gobuffalo/envy](https://godoc.org/github.com/gobuffalo/envy)
+* [github.com/joho/godotenv](https://godoc.org/github.com/joho/godotenv)
 * [github.com/gobuffalo/events](https://godoc.org/github.com/gobuffalo/events)
 * [github.com/gobuffalo/flect](https://godoc.org/github.com/gobuffalo/flect)
 * [github.com/gobuffalo/github_flavored_markdown](https://godoc.org/github.com/gobuffalo/github_flavored_markdown)
-* [github.com/gobuffalo/grift](https://godoc.org/github.com/gobuffalo/grift)
 * [github.com/gobuffalo/helpers](https://godoc.org/github.com/gobuffalo/helpers)
 * [github.com/gobuffalo/here](https://godoc.org/github.com/gobuffalo/here)
 * [github.com/gobuffalo/httptest](https://godoc.org/github.com/gobuffalo/httptest)

app.go

@@ -5,7 +5,7 @@ import (
 	"net/http"
 	"sync"
 
-	"github.com/gobuffalo/envy"
+	"github.com/gobuffalo/buffalo/internal/env"
 	"github.com/gorilla/mux"
 )
 
@@ -36,7 +36,7 @@ func (a *App) Muxer() *mux.Router {
 // New returns a new instance of App and adds some sane, and useful, defaults.
 func New(opts Options) *App {
 	LoadPlugins()
-	envy.Load()
+	env.Load()
 
 	opts = optionsWithDefaults(opts)
 

binding/binding.go

@@ -5,7 +5,7 @@ import (
 	"time"
 
 	"github.com/gobuffalo/buffalo/binding/decoders"
-	"github.com/gobuffalo/nulls"
+	"github.com/gobuffalo/buffalo/internal/nulls"
 	"github.com/monoculum/formam"
 )
 

binding/decoders/null_time.go

@@ -1,6 +1,6 @@
 package decoders
 
-import "github.com/gobuffalo/nulls"
+import "github.com/gobuffalo/buffalo/internal/nulls"
 
 // NullTimeDecoderFn is a custom type decoder func for null.Time fields
 func NullTimeDecoderFn() func([]string) (interface{}, error) {

binding/decoders/null_time_test.go

@@ -4,7 +4,7 @@ import (
 	"testing"
 	"time"
 
-	"github.com/gobuffalo/nulls"
+	"github.com/gobuffalo/buffalo/internal/nulls"
 	"github.com/stretchr/testify/require"
 )
 

errors.go

@@ -87,9 +87,9 @@ func (a *App) PanicHandler(next Handler) Handler {
 				case error:
 					err = t
 				case string:
-					err = fmt.Errorf(t)
+					err = fmt.Errorf("%s", t)
 				default:
-					err = fmt.Errorf(fmt.Sprint(t))
+					err = fmt.Errorf("%s", fmt.Sprint(t))
 				}
 
 				payload := events.Payload{

errors_test.go

@@ -13,7 +13,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-//testLoggerHook is useful to test whats being logged.
+// testLoggerHook is useful to test whats being logged.
 type testLoggerHook struct {
 	errors []*logrus.Entry
 }
@@ -172,7 +172,7 @@ func Test_PanicHandler(t *testing.T) {
 		t.Run(tt.path, func(st *testing.T) {
 			r := require.New(st)
 
-			res := w.HTML(tt.path).Get()
+			res := w.HTML("%s", tt.path).Get()
 			r.Equal(http.StatusInternalServerError, res.Code)
 
 			body := res.Body.String()

flash.go

@@ -5,27 +5,27 @@ import "encoding/json"
 // flashKey is the prefix inside the Session.
 const flashKey = "_flash_"
 
-//Flash is a struct that helps with the operations over flash messages.
+// Flash is a struct that helps with the operations over flash messages.
 type Flash struct {
 	data map[string][]string
 }
 
-//Delete removes a particular key from the Flash.
+// Delete removes a particular key from the Flash.
 func (f Flash) Delete(key string) {
 	delete(f.data, key)
 }
 
-//Clear removes all keys from the Flash.
+// Clear removes all keys from the Flash.
 func (f *Flash) Clear() {
 	f.data = map[string][]string{}
 }
 
-//Set allows to set a list of values into a particular key.
+// Set allows to set a list of values into a particular key.
 func (f Flash) Set(key string, values []string) {
 	f.data[key] = values
 }
 
-//Add adds a flash value for a flash key, if the key already has values the list for that value grows.
+// Add adds a flash value for a flash key, if the key already has values the list for that value grows.
 func (f Flash) Add(key, value string) {
 	if len(f.data[key]) == 0 {
 		f.data[key] = []string{value}
@@ -35,13 +35,13 @@ func (f Flash) Add(key, value string) {
 	f.data[key] = append(f.data[key], value)
 }
 
-//Persist the flash inside the session.
+// Persist the flash inside the session.
 func (f Flash) persist(session *Session) {
 	b, _ := json.Marshal(f.data)
 	session.Set(flashKey, b)
 }
 
-//newFlash creates a new Flash and loads the session data inside its data.
+// newFlash creates a new Flash and loads the session data inside its data.
 func newFlash(session *Session) *Flash {
 	result := &Flash{
 		data: map[string][]string{},

go.mod

@@ -1,34 +1,31 @@
 module github.com/gobuffalo/buffalo
 
-go 1.23.0
+go 1.25.0
 
 require (
 	github.com/BurntSushi/toml v1.2.1
-	github.com/dustin/go-humanize v1.0.1
-	github.com/gobuffalo/envy v1.10.2
 	github.com/gobuffalo/events v1.4.3
 	github.com/gobuffalo/flect v1.0.2
 	github.com/gobuffalo/github_flavored_markdown v1.1.3
-	github.com/gobuffalo/grift v1.5.2
 	github.com/gobuffalo/helpers v0.6.10
 	github.com/gobuffalo/httptest v1.5.2
 	github.com/gobuffalo/logger v1.0.7
 	github.com/gobuffalo/meta v0.3.3
-	github.com/gobuffalo/nulls v0.4.2
 	github.com/gobuffalo/plush/v5 v5.0.4
 	github.com/gobuffalo/refresh v1.13.3
 	github.com/gobuffalo/tags/v3 v3.1.4
 	github.com/gorilla/handlers v1.5.1
 	github.com/gorilla/mux v1.8.0
 	github.com/gorilla/sessions v1.2.1
 	github.com/monoculum/formam v3.5.5+incompatible
-	github.com/psanford/memfs v0.0.0-20210214183328-a001468d78ef
 	github.com/sirupsen/logrus v1.9.0
 	github.com/spf13/cobra v1.6.1
 	github.com/stretchr/testify v1.9.0
 	golang.org/x/text v0.25.0
 )
 
+require github.com/gobuffalo/envy v1.10.2 // indirect
+
 require (
 	github.com/aymerick/douceur v0.2.0 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
@@ -41,7 +38,7 @@ require (
 	github.com/gorilla/css v1.0.0 // indirect
 	github.com/gorilla/securecookie v1.1.1 // indirect
 	github.com/inconshreveable/mousetrap v1.0.1 // indirect
-	github.com/joho/godotenv v1.4.0 // indirect
+	github.com/joho/godotenv v1.4.0
 	github.com/mattn/go-colorable v0.1.9 // indirect
 	github.com/mattn/go-isatty v0.0.14 // indirect
 	github.com/microcosm-cc/bluemonday v1.0.20 // indirect