writer: more verbose variable naming to have better docs

Author: gobwas

cmd/gtrace/main.go

@@ -327,7 +327,14 @@ func buildFunc(info types.Info, fn *ast.FuncType) (ret Func, err error) {
 		if t == nil {
 			log.Fatalf("unknown type: %s", p.Type)
 		}
-		ret.Params = append(ret.Params, t)
+		var name string
+		if len(p.Names) > 0 {
+			name = p.Names[0].Name
+		}
+		ret.Params = append(ret.Params, Param{
+			Name: name,
+			Type: t,
+		})
 	}
 	if fn.Results == nil {
 		return ret, nil
@@ -404,8 +411,13 @@ type Hook struct {
 	Func Func
 }
 
+type Param struct {
+	Name string // Might be empty.
+	Type types.Type
+}
+
 type Func struct {
-	Params []types.Type
+	Params []Param
 	Result []Func // 0 or 1.
 }
 
@@ -473,6 +485,14 @@ func split(s string, c byte) (s1, s2 string) {
 	return s[:i], s[i+1:]
 }
 
+func rsplit(s string, c byte) (s1, s2 string) {
+	i := strings.LastIndexByte(s, c)
+	if i == -1 {
+		return s, ""
+	}
+	return s[:i], s[i+1:]
+}
+
 func scanBuildConstraints(r io.Reader) (cs []string, err error) {
 	br := bufio.NewReader(r)
 	for {