Skip to content

Commit 67cfed1

Browse files
authored
Fix incorrect label for page selection on account settings tab (#2731)
* Adding placeholder. * Adding changelog.
1 parent 7cc0130 commit 67cfed1

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
significance: patch
2+
type: fixed
3+
links:
4+
- "#2708"
5+
entry: Fixes placeholder label on the Dashboard Page selection dropdown.

includes/admin/settings/class.llms.settings.accounts.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,8 @@ public function get_settings() {
7171
'class' => 'llms-select2-post',
7272
'type' => 'select',
7373
'custom_attributes' => array(
74-
'data-post-type' => 'page',
74+
'data-post-type' => 'page',
75+
'data-placeholder' => __( 'Select a page', 'lifterlms' ),
7576
),
7677
'options' => llms_make_select2_post_array( get_option( 'lifterlms_myaccount_page_id', '' ) ),
7778
),
@@ -372,7 +373,6 @@ public function get_settings() {
372373
* @param array $account_settings The account page settings.
373374
*/
374375
return apply_filters( "lifterlms_{$this->id}_settings", $account_settings );
375-
376376
}
377377

378378
/**
@@ -385,7 +385,6 @@ public function get_settings() {
385385
protected function set_label() {
386386
return __( 'Accounts', 'lifterlms' );
387387
}
388-
389388
}
390389

391390
return new LLMS_Settings_Accounts();

0 commit comments

Comments
 (0)