diff --git a/.changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml b/.changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml new file mode 100644 index 0000000000..0c2d37e6cc --- /dev/null +++ b/.changelogs/fix_incorrect-label-for-page-selection-on-account-settings-tab.yml @@ -0,0 +1,5 @@ +significance: patch +type: fixed +links: + - "#2708" +entry: Fixes placeholder label on the Dashboard Page selection dropdown. diff --git a/includes/admin/settings/class.llms.settings.accounts.php b/includes/admin/settings/class.llms.settings.accounts.php index 840b7a94bb..545153f00d 100644 --- a/includes/admin/settings/class.llms.settings.accounts.php +++ b/includes/admin/settings/class.llms.settings.accounts.php @@ -71,7 +71,8 @@ public function get_settings() { 'class' => 'llms-select2-post', 'type' => 'select', 'custom_attributes' => array( - 'data-post-type' => 'page', + 'data-post-type' => 'page', + 'data-placeholder' => __( 'Select a page', 'lifterlms' ), ), 'options' => llms_make_select2_post_array( get_option( 'lifterlms_myaccount_page_id', '' ) ), ), @@ -372,7 +373,6 @@ public function get_settings() { * @param array $account_settings The account page settings. */ return apply_filters( "lifterlms_{$this->id}_settings", $account_settings ); - } /** @@ -385,7 +385,6 @@ public function get_settings() { protected function set_label() { return __( 'Accounts', 'lifterlms' ); } - } return new LLMS_Settings_Accounts();