Skip to content

Commit 0b6c4f6

Browse files
[PFX-919] - force eslint-plugin-react-hooks version on different code styles (#1098)
* force eslint-plugin-react-hooks version on different code styles * add test case * CHANGESET * Update .changeset/ninety-cows-work.md Co-authored-by: Andrew Gerard <[email protected]> --------- Co-authored-by: Andrew Gerard <[email protected]>
1 parent 98e27f0 commit 0b6c4f6

File tree

3 files changed

+32
-3
lines changed

3 files changed

+32
-3
lines changed

.changeset/ninety-cows-work.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@gasket/plugin-lint": patch
3+
---
4+
5+
force eslint-plugin-react-hooks version on different code styles

packages/gasket-plugin-lint/lib/utils.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ function makeGatherDevDeps() {
1414
var eslintImport = { 'eslint-plugin-import': '^2.27.5' };
1515

1616
var dependencies = {
17-
'eslint-config-godaddy': { ...eslintBaseDeps, 'eslint-config-godaddy': '^7.1.1' },
18-
'eslint-config-godaddy-react': { ...eslintBaseDeps, 'eslint-config-godaddy-react': '^9.1.0', ...babelCore },
17+
'eslint-config-godaddy': { ...eslintBaseDeps, 'eslint-config-godaddy': '^7.1.1', 'eslint-plugin-react-hooks': '^4.6.0' },
18+
'eslint-config-godaddy-react': { ...eslintBaseDeps, 'eslint-config-godaddy-react': '^9.1.0', 'eslint-plugin-react-hooks': '^4.6.0', ...babelCore },
1919
'eslint-config-godaddy-flow': { ...eslintBaseDeps, 'eslint-config-godaddy-flow': '^6.0.2', ...babelCore },
2020
'eslint-config-godaddy-react-flow': { ...eslintBaseDeps, 'eslint-config-godaddy-react-flow': '^6.0.2', ...babelCore },
2121
'@godaddy/eslint-plugin-react-intl': { ...eslintBaseDeps, '@godaddy/eslint-plugin-react-intl': '^1.3.0' },

packages/gasket-plugin-lint/test/utils.test.js

+25-1
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,32 @@ describe('utils', () => {
2323
});
2424

2525
it('gatherDevDeps returns hardcoded version', () => {
26-
const results = gatherDevDeps('eslint-config-airbnb');
26+
const results = gatherDevDeps('stylelint-config-airbnb');
2727
expect(results).toEqual({
28+
'stylelint-config-airbnb': '^0.0.0',
29+
'stylelint': '^8.0.0',
30+
'stylelint-order': '^0.7.0',
31+
'stylelint-scss': '^1.2.1'
32+
});
33+
});
34+
35+
it('defines eslint-plugin-react-hooks for relevant packages', () => {
36+
const results = gatherDevDeps('eslint-config-godaddy-react');
37+
expect(results).toEqual({
38+
'eslint-config-godaddy-react': '^9.1.0',
39+
'eslint': '^8.57.1',
40+
'@babel/core': '>=7',
41+
'eslint-plugin-react-hooks': '^4.6.0'
42+
});
43+
44+
const results2 = gatherDevDeps('eslint-config-godaddy-flow');
45+
expect(results2).toEqual({
46+
'eslint-config-godaddy-flow': '^6.0.2',
47+
'eslint': '^8.57.1',
48+
'@babel/core': '>=7'
49+
});
50+
const results3 = gatherDevDeps('eslint-config-airbnb');
51+
expect(results3).toEqual({
2852
'eslint-config-airbnb': '^19.0.4',
2953
'eslint': '^8.57.1',
3054
'eslint-plugin-import': '^2.27.5',

0 commit comments

Comments
 (0)